Update tennis-standings extension

[drillprop]

Description

Follow up of #12248

Screencast

Ekran.10.maj.2024.12.54.mp4

Checklist

• I read the extension guidelines
• I read the documentation about publishing
• I ran npm run build and tested this distribution build in Raycast
• I checked that files in the assets folder are used by the extension itself
• I checked that assets used by the README are placed outside of the metadata folder

[raycastbot]

Thank you for your contribution! 🎉

🔔 @faisal3389 @xilopaint you might want to have a look.

[xilopaint]

I still prefer the leaderboard icon over repeating Points:. Also, I believe it's more common to use Rankings (in the plural form), in this context, than the singular form Ranking. The rest looks good to me.

EDIT: I didn't see the code, just the screencast.

[drillprop]

Thanks for the feedback.

Also, I believe it's more common to use Rankings (in the plural form), in this context, than the singular form Ranking.

Sure, I'll fix that.

I still prefer the leaderboard icon over repeating Points:.

I find the leaderboard icon a bit unclear in terms of its meaning. What about stars? 👇🏻

VS

[xilopaint]

I don't see how the star can be clearer than the leaderboard icon. The tennis standings are essentially leaderboard positions. An alternative is using the pts abbreviation after the points (e.g. 10760 pts), but I didn't test to see how it looks.

There's also redundancy in the dropdown. You don't need the "Filter by country" section if you're already using the same message as a placeholder:

[xilopaint]

Thinking a bit more, I would also recommend against using emojis in the rankings. It's impossible to know all the flags. Look at the current WTA rankings:

With all due respect, I have no clue what the flags of Belarus and Kazakhstan look like, even though those are two top-10 players. Your emojis are not helpful for smaller countries. I much prefer the previous way of presenting the countries. Furthermore, emojis are known to impoverish the design and make it inconsistent.

[drillprop]

@xilopaint

Also, I believe it's more common to use Rankings (in the plural form), in this context, than the singular form Ranking.

fixed

There's also redundancy in the dropdown. You don't need the "Filter by country" section if you're already using the same message as a placeholder:

fixed

I don't see how the star can be clearer than the leaderboard icon. The tennis standings are essentially leaderboard positions. An alternative is using the pts abbreviation after the points (e.g. 10760 pts), but I didn't test to see how it looks.

I'm still not convinced by this. I find the icon blurry - it looks to me like some buildings and a star on top of it. It doesn't look like a podium to me. Also, the numbers on the right of the icon don't tell about the player's position but about the player's points, so the leaderboard semantically doesn't fit here IMO.
But anyway, I won't be arguing here - I set the leaderboard icon like you want. Fixed

Regarding emojis and countries:

Furthermore, emojis are known to impoverish the design and make it inconsistent.

Sure, I understand your point and partly agree. But If I would set the name of the country close to the name(using subtitle prop) as you suggest, it would be more actually confusing. I use the subtitle to show ranking changes since the last ranking release, and If I would add a country close to it, it wouldn't be really incomprehensible. This is how it would look 👇🏻

Removing ranking change is not an option - IMO this information is more important in the leaderboard extension than showing the name country. You want to know how players progress through the season.

With all due respect, I have no clue what the flags of Belarus and Kazakhstan look like, even though those are two top-10 players.

You can always check the player's country name by checking the player's details. So you can access this information very easily, actually.

Also, to convince you a little bit more, there is a very similar extension already that uses the same pattern with emojis.

So in the end I left emojis and countries as it is.

After fixing the requested changes here's how the extension looks:

[xilopaint]

I find the icon blurry - it looks to me like some buildings and a star on top of it. It doesn't look like a podium to me. Also, the numbers on the right of the icon don't tell about the player's position but about the player's points, so the leaderboard semantically doesn't fit here IMO.

A podium is basically what you get when you search for "ranking" in Iconify:

Yet, if you think Icon.Leaderboard can be improved, you can always talk to the Raycast design team. New icons can also be requested. Or do you think it would be a better option not to use any icon at all, as in the Formula 1 extension you showed?

But If I would set the name of the country close to the name(using subtitle prop) as you suggest, it would be more actually confusing. I use the subtitle to show ranking changes since the last ranking release, and If I would add a country close to it, it wouldn't be really incomprehensible.

I see your point. To be honest, I can't find a good solution to accommodate everything. The emojis make the design look cheap, no wonder you won't find them in Raycast built-in extensions. But in the absence of a better alternative, let's leave them in the list view as you suggested. I only think it's too much using the flag ahead of the country name. In the dropdown I would remove the emojis and prove with Icon.Globe for "All countries" and Icon.Map for each country.

I would also remove the emoji in the player's details because it looks ugly and unnecessary.

[pernielsentikaer]

We can also move flags to accessories, I'm not sure if it makes it less cluttered? We can also make a preference to not show the flag if you don't like that @xilopaint

[xilopaint]

We can also make a preference to not show the flag if you don't like that @xilopaint

Not necessary. I'm not the extension author, just a contributor, and this PR brings good improvements.

I would remove the flags from the dropdown and the player's details, but it's just my opinion. @drillprop can have the final say here.

[pernielsentikaer]

I actually like the flags, for me it brings value to have it

@drillprop is this all ready to be merged?

[drillprop]

I actually like the flags, for me it brings value to have it

@drillprop is this all ready to be merged?

I was busy for the last few days and I couldn't answer. I would also keep the flags, especially in the dropdown. With all due respect, I don't like the idea of setting repetitive Map icons.

Yes, it's ready to be merged.

[pernielsentikaer]

Hi 👋

Looks good to me, approved 🔥

[github-actions]

Published to the Raycast Store:
https://raycast.com/Zalgo_123/tennis-standings

[raycastbot]

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.