Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipExtractor arguments do not use arguments specified in XML file and instead use arguments from the command line #668

Open
Bongo9911 opened this issue Mar 1, 2024 · 4 comments

Comments

@Bongo9911
Copy link

Bongo9911 commented Mar 1, 2024

I'm trying to set custom arguments to be used after the application is updated and restarted using the ZipExtractor. I have set the <args> inside of my XML file, however they appear to be getting overwritten with arguments passed to the command line when the application was ran before the update. It appears that in DownloadUpdateDialog.cs that the installerArgs are being overwritten with the command line arguments even if there are arguments present in the XML file.

I believe there should be a check if there are installerArgs present in the XML file, and if there are it should use those. Otherwise, it should use the arguments from the command line. Does this sound correct?

@ravibpatel
Copy link
Owner

Are you using a Zip file as an update file or installer?

@Bongo9911
Copy link
Author

I have a ZIP folder which contains all the application's files and the path to it is set in the <url> portion of the XML file

@ravibpatel
Copy link
Owner

<args> element is used to provide arguments for installer. Since you are not using the installer, then it will be ignored cause it uses ZipExtractor, which is specifically built to extract zip files.

@Bongo9911
Copy link
Author

Bongo9911 commented Mar 7, 2024

However, the ZipExtractor does restart the application after extracting the files using the arguments that were passed to the application when it was started prior to the update. I'd like a way to override these arguments for when it restarts after updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants