Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate MS support into xds_{from,to}_ms #273

Open
Tracked by #285
sjperkins opened this issue Dec 5, 2022 · 1 comment
Open
Tracked by #285

Consolidate MS support into xds_{from,to}_ms #273

sjperkins opened this issue Dec 5, 2022 · 1 comment

Comments

@sjperkins
Copy link
Member

sjperkins commented Dec 5, 2022

  • dask-ms version: 0.2.15
  • Python version: 3.8
  • Operating System: Ubuntu 20.04

In #272, @caseyjlaw tried to use xds_from_ms to open a sub-table of the MS. This didn't work because xds_from_ms adds some default values (grouping and indexing columns) for opening the MAIN table of an MS. Due to this, we currently use xds_from_table to access sub-tables in our applications.

However, it occurs to me that @caseyjlaw was trying to do the most obvious thing, given the affordance. It could be that split is unnecessary and confusing and that xds_{from,to}_ms should be the interface for dealing with all Measurement Set-like datastores (CASA/zarr/parquet), as well as their sub-tables.

Then, xds_{from,to}_table can be used for general undefined table types, and we could define xds_{from,to}_xxx methods to handle some xxx specification (calibration methods for example).

Any opinions on this @JSKenyon, @landmanbester, @o-smirnov ?

@JSKenyon
Copy link
Collaborator

JSKenyon commented Dec 5, 2022

I had had a similar thought and I am all for it. This would likely be a breaking change, but I think it would be worth it. It means that we can abandon MS-like syntax in xds_{to,from}_table (i.e. don't introduce a MAIN table for no reason) and remove the unintuitive double colon syntax that it necessitated. This functionality can be retained/added in xds_{to,from}_ms to make it "equivalent" with MS access via python-casacore. I think that xds_{to,from}_table should be sufficient for all other use-cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants