Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat the git-cliff release notes #1060

Open
joshka opened this issue Apr 24, 2024 · 7 comments
Open

Reformat the git-cliff release notes #1060

joshka opened this issue Apr 24, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@joshka
Copy link
Member

joshka commented Apr 24, 2024

Problem

I'd like to see a much more compact summary of changes in each release that works well with dependabot and other tooling.
E.g. joshka/ratatui-widgets#22 truncates the changelog
It looks like we also get double headers for some reason. (v0.26.2 and then v0.26.2 2024-04-15)

Solution

A top section that just directly lists the commit message titles e.g.:

Summary

  • fea(layout): Mark various functions as const #951
  • ...

Pinging @orhun for additonal thoughts

@joshka joshka added the enhancement New feature or request label Apr 24, 2024
@orhun
Copy link
Sponsor Member

orhun commented Apr 26, 2024

It looks like we also get double headers for some reason. (v0.26.2 and then v0.26.2 2024-04-15)

I'm unable to reproduce this, can you show me an example?

A top section that just directly lists the commit message titles e.g.:

Yeah, it should be fairly simple to do that. Looks similar to the github template example.

A couple of questions:

  • Are you proposing the revamp the entire changelog format or just adding a summary?
  • What's wrong with the current format? Yeah it's long but everything is there. I especially like the fact that we include the commit body. Maybe we can make it a collapsible content though, not sure.

@joshka
Copy link
Member Author

joshka commented Apr 27, 2024

I'm unable to reproduce this, can you show me an example?

Details

https://github.com/ratatui-org/ratatui/releases/tag/v0.26.2
image

joshka/tui-scrollview#28
image

Compare: joshka/tui-scrollview#14

image

Are you proposing the revamp the entire changelog format or just adding a summary?

Change the format so that the important information is up top in the zone that doesn't get truncated by the tooling around releases.

What's wrong with the current format? Yeah it's long but everything is there. I especially like the fact that we include the commit body. Maybe we can make it a collapsible content though, not sure.

I'd like to see this in a format that works well with the ecosystem of tools that are in use. That includes dependabot, github releases, and the github home feed. Long is fine, but for the most part, tools truncate things the changelog / release notes, so it's important to include the right information up front:

image

and joshka/tui-scrollview#28

image image

@orhun
Copy link
Sponsor Member

orhun commented Apr 28, 2024

Okay I see what you mean. Regarding Dependabot duplicating the header, it might be happening due to multiple things. Maybe it's because we're missing v, using ## instead of # or even including the link. I'm not sure how to fix that, but we can try to keep it simple by just including the version (similar to mio) next time and hope that it doesn't duplicate it. It's lowkey brute forcing, but I really don't want to dig into some Ruby code to find it out. But I digged in anyways: https://github.com/dependabot/dependabot-core/blob/7b25e935cd0a1f9a89abf6ce865cea69090c298d/common/lib/dependabot/metadata_finders/base/changelog_finder.rb#L57

Do you think adding a summary section to the top of the changelog only from the "feature" commits is a good idea?

For example (assume they are all feature commits):

## Summary
* docs(github): update code owners about past maintainers
* fix(examples): changed user_input example to work with multi-byte unicode chars by @OkieOth in [#1069](https://github.com/ratatui-org/ratatui/pull/1069)
* fix(examples): fix key handling in constraints by @psobolik in [#1066](https://github.com/ratatui-org/ratatui/pull/1066)
* docs(github): update code owners by @orhun in [#1067](https://github.com/ratatui-org/ratatui/pull/1067)

But then we will be duplicating the entries in the changelog, hmm..

@joshka
Copy link
Member Author

joshka commented Apr 28, 2024

I'm not too sure. Btw, this is very much one of those places which is about gold plating, but I've called it out as you own git cliff and gold plating here might help the wider git cliff perspective.

@orhun
Copy link
Sponsor Member

orhun commented May 18, 2024

What do you think of doing something like the following for less verbosity?

97ee102 (buffer) Track_caller for index_of by @EdJoPaTo in #1046

The caller put in the wrong x/y -> the caller is the cause.

@orhun
Copy link
Sponsor Member

orhun commented May 18, 2024

sorry for the false ping, I just wanted to share an example :D

@joshka
Copy link
Member Author

joshka commented May 19, 2024

What do you think of doing something like the following for less verbosity?

I don't think there's a way to make the summary interpret markdown on the first line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants