Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vhs tapes and images for the new constraint explorer / flex examples #1014

Open
joshka opened this issue Apr 1, 2024 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@joshka
Copy link
Member

joshka commented Apr 1, 2024

Problem

The examples readme is missing images for the new examples (flex and constraints explorer)
There is a VHS tape for flex, but not for the explorer.

Solution

  • Generate / update the tapes
  • Check if there are other missing tapes
  • Generate the images (gifs / pngs)
  • Add the images to the images branch of this repo
  • Update the readme to point at the new images

Constraints

  • Match the sizes and font from the other tapes (adjust height to make sense, but width should be generally consistent)
  • Images should generally not be frantic (lots of fast animation). Always leave enough time for people to read any changes. (usually around 2s or so after any significant animation seems to work)
  • Images need to be under 5MB to be able to be able to be displayed on github.
  • Use a PNG if that conveys all the info, use a GIF if the animation will be useful.
@joshka joshka added the enhancement New feature or request label Apr 1, 2024
@orhun
Copy link
Sponsor Member

orhun commented Apr 1, 2024

Maybe a good first issue?

@joshka joshka added the good first issue Good for newcomers label Apr 1, 2024
@joshka
Copy link
Member Author

joshka commented Apr 1, 2024

Maybe a good first issue?

Added some constraints to make it clearer and yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants