Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dynamic Port Description configuration #20

Open
Voljka1 opened this issue Feb 12, 2018 · 1 comment
Open

More dynamic Port Description configuration #20

Voljka1 opened this issue Feb 12, 2018 · 1 comment

Comments

@Voljka1
Copy link

Voljka1 commented Feb 12, 2018

  • [ x] Request for enhancement
    Hello. Thanks for your efforts, really :)
  1. I tried latest version and found what I am unable to set PortDescription to just "Ethernet Adaptor".
    At same time SystemDescription can be set like "Personal Computer"
    =======
    $config = New-Object WinLLDPService.Configuration
    $config.PortDescription="Ethernet adapter"
    $config.SystemDescription="Personal Computer"
    Return $config
    =======
  2. Please add more examples, how to change info in ps1 config, I did google for powershell examples on getting PC info, but failed to understood how to modify config script.
  3. my biggest sadness: for this service to work, I need loosen powershell scripts permissions.
    Can you keep things to absolute minimum? may be read registry keys, what can survive sysprep?
    I want to install PC, setup winlldp service and sysprep it. And have as little as possible security risks.
  4. IPv6 addresses in Management Address TLV need to be written in hex form IMHO.
    like "fd74:24b5:ff8d:d:a424:c342:2821:715c". Currently they are looks like "253.116.36.181:255.141.0.13:200.248.24.162:0.110.39.216". Not very useful.
@raspi
Copy link
Owner

raspi commented Feb 13, 2018

tried latest version and found what I am unable to set PortDescription to just "Ethernet Adaptor".
At same time SystemDescription can be set like "Personal Computer"

Port description is not configurable (yet). Could you give a reason why it should be?

I have for example three network adapters and currently the adapter information is fetched from the OS so that sysadmins can know which actual NIC is connected to which port. If port description was configurable all three cards would say "Ethernet Adapter" which isn't useful. Now I know for example that "Intel NIC (LAN)" is connected to switch 1 and "Realtek NIC (Management)" to switch 2.

Please add more examples, how to change info in ps1 config, I did google for powershell examples on getting PC info, but failed to understood how to modify config script.

I've now added more examples.

my biggest sadness: for this service to work, I need loosen powershell scripts permissions.

AllSigned ExecutionPolicy is highly recommended.

Can you keep things to absolute minimum? may be read registry keys, what can survive sysprep?
I want to install PC, setup winlldp service and sysprep it. And have as little as possible security risks.

PowerShell was chosen so that information sent is flexible as possible. For example system administrator A might want OS name such as Windows 10 Pro and system administrator B might want OS version such as 10.0.16299.0 and system administrator C might want Windows 10 Pro 10.0.16299.0. If the configuration was minimal as possible this flexibility isn't then available.

You can add ExecutionPolicy and the configuration file with sysprep.

IPv6 addresses in Management Address TLV need to be written in hex form IMHO.

IPv6 address is sent correctly. Please check your switch/lldp agent configuration/manual and possible updates. Your user interface is probably messing it up. It is also possible that it doesn't support multiple IPs.

Please join chat @ https://gitter.im/raspi/WinLLDPService for more free-form discussion.

@raspi raspi self-assigned this Feb 13, 2018
@raspi raspi changed the title Service configuration More dynamic Port Description configuration Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants