Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pandas dataframes in bias-variance-docmposition #1070

Open
prateek-bricklane opened this issue Oct 24, 2023 · 3 comments
Open

Using pandas dataframes in bias-variance-docmposition #1070

prateek-bricklane opened this issue Oct 24, 2023 · 3 comments

Comments

@prateek-bricklane
Copy link

Describe the workflow you want to enable

Using bias variance decomposition with pandas dataframe. Since scikit learn now supports pandas api train test splits are available as pandas dataframes for some workflows. Raising an error when passing these as inputs to bias_variance_decomp, just makes us use an extra step outside mlxtend that is out of context of more general workflow (that is accomplished entire in pandas dataframes).

Describe your proposed solution

Instead of raising error with a message, convert pandas dataframes to numpy arrays internally.

Describe alternatives you've considered, if relevant

An alternative would be a config parameter for the package like scikit-learn that can more generally handle dataframes across range of functionalities either by converting to numpy arrays or implementing functionalities compatible with dataframes.

Additional context

@rasbt
Copy link
Owner

rasbt commented Oct 28, 2023

Thanks for the suggestion. This would be a nice addition indeed. Unfortunately, I am a bit overcommitted and don't know when/if I would have time to implement this.

@prateek-bricklane
Copy link
Author

Happy to give it a try :)

@rasbt
Copy link
Owner

rasbt commented Oct 31, 2023

If you have time and are interested to work on this, I'd appreciate the contribution 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants