Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python pre-3.9 logic #696

Open
jakirkham opened this issue Feb 7, 2024 · 4 comments
Open

Drop Python pre-3.9 logic #696

jakirkham opened this issue Feb 7, 2024 · 4 comments
Milestone

Comments

@jakirkham
Copy link
Member

There is some leftover logic for older Python versions (pre-3.9). As we require Python 3.9+, this logic can be dropped. Would be good to clean things up a bit

@jakirkham
Copy link
Member Author

Here's one instance

if hasattr(math, "prod"):
prod = math.prod # available in Python 3.8+ only
else:
prod = numpy.prod

@jakirkham
Copy link
Member Author

Also these constraints could be refreshed

cucim/dependencies.yaml

Lines 206 to 209 in d4ec01e

- matrix:
py: "3.8"
packages:
- python=3.8

cucim/dependencies.yaml

Lines 218 to 220 in d4ec01e

- matrix:
packages:
- python>=3.8,<3.11

@jakirkham
Copy link
Member Author

We may also want to rerun the notebooks. For example:

"version": "3.8.10"

@jakirkham
Copy link
Member Author

Might be worth adding pyupgrade to pre-commit

@jakirkham jakirkham added this to the v24.06 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant