Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Tab indicator doesn't disappear #493

Open
MrPandir opened this issue Apr 23, 2024 · 2 comments
Open

[Bug] Tab indicator doesn't disappear #493

MrPandir opened this issue Apr 23, 2024 · 2 comments

Comments

@MrPandir
Copy link

If you delete the first tab, the terminal automatically switches to the second tab, but the tab indicators are not updated.
If you create a new tab and delete it (it will be the second one), the tab indicators will disappear. I expect the same behavior when deleting the first tab.

Video

Screen.Recording.2024-04-23.at.15.48.05.mov

Additional Information

Rio Version: 0.0.36
OS: macOS 14.4
Config:

cursor = ''
blinking-cursor = false
confirm-before-quit = false
[navigation]
mode = "CollapsedTab"
@raphamorim
Copy link
Owner

Hey @MrPandir thanks for the issue,

So to confirm if I understood it correctly, what you mean is that tab should be there and not disappear even if is the last one?

@MrPandir
Copy link
Author

So to confirm if I understood it correctly, what you mean is that tab should be there and not disappear even if is the last one?

No. The display of tab indicators should always disappear when there is only one tab. This is how it is implemented in other terminals.

The bug is that if you delete the first tab (⌘ + 1), it will not be reflected in the indicators.
So if you have 4 tabs:

* * * *
^

You delete the first tab by pressing ⌘ + w or exit in the terminal.
Now we have 3 tabs. The terminal will automatically switch to the next tab, but this will not update the indicators.
The indicators will still be four, which is false:

* * * *
^

When it is expected to be displayed as:

* * *
^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants