Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Rio's own powerline symbols #448

Open
mhartington opened this issue Feb 5, 2024 · 1 comment
Open

Provide Rio's own powerline symbols #448

mhartington opened this issue Feb 5, 2024 · 1 comment

Comments

@mhartington
Copy link

With my rio config, I set the line height at 1.5 so it's a bit easier to read. With that set, though, certain powerline gylphs end up looking too small for the allotted space.

Screenshot 2024-02-05 at 9 39 20 AM

This is to be expected, though, since the line height doesn't actually modify the font. In iterm, they provide an option to deal with this, where powerline glyphs can be swapped for internal one. These internal powerline glyphs will match the line height and look correct, regardless of what the user sets.

Screenshot 2024-02-05 at 9 44 26 AM

And in action, you can see the swap between the glyphs my font provides, and the built-in ones.

Screen.Recording.2024-02-05.at.9.46.55.AM.mov
@raphamorim
Copy link
Owner

Hey there @mhartington thanks for the issue, sorry about delay to reply.

This is to be expected, though, since the line height doesn't actually modify the font. In iterm, they provide an option to deal with this, where powerline glyphs can be swapped for internal one. These internal powerline glyphs will match the line height and look correct, regardless of what the user sets.

Yes I was going to say this. Thanks for sharing about the iTerm2 solution, I didn't know that. Currently I am working in a major rewrite of the renderer to support a decent line-height calculation (#428) but probably it will not fix this issue either. Then I wonder what might be the best fix for this case, thinking in allow scale certain glyphs via configuration (in this case the powerline icons) to match the line or a specific size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants