Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Paste is pasting twice #419

Open
gplusplus314 opened this issue Jan 17, 2024 · 4 comments
Open

[Bug] Paste is pasting twice #419

gplusplus314 opened this issue Jan 17, 2024 · 4 comments

Comments

@gplusplus314
Copy link

When pasting text into Rio, the text is pasted twice.

Reproduction:

  1. Copy any text from anywhere, including Rio itself.
  2. Paste it into Rio

My environment:

OS: Windows 11 Pro 23H2, 22631.3007
Rio version: rel v0.0.34

entire config:

config.toml

cursor = ''
blinking-cursor = false

ignore_theme_selection_fg_color = false

performance = "High"

[window]
decorations = "Disabled"

[fonts]
family = "SauceCodePro Nerd Font"
size = 20
[fonts.regular]
weight = 400
[fonts.bold]
weight = 600
[fonts.italic]
weight = 400
[fonts.bold-italic]
weight = 600

[navigation]
mode = "BottomTab"
clickable = true
use-current-path = true
# color-automation = []
# macos-hide-window-buttons = true

[shell]
program = "nu.exe"
args = []

[colors]
tabs = '#111111'
tabs-active = '#5500AA'
cursor = '#00DD00'
selection-foreground = '#000000'
selection-background = '#AAAA00'

[bindings]
keys = [
	# Disable most defaults
	{ key = ",", with = "control | shift", action = "ReceiveChar" },
	{ key = "space", with = "alt | shift", action = "ReceiveChar" },
	{ key = "n", with = "control | shift", action = "ReceiveChar" },
	{ key = "t", with = "control | shift", action = "ReceiveChar" },
	{ key = "tab", with = "control", action = "ReceiveChar" },
	{ key = "]", with = "control | shift", action = "ReceiveChar" },
	{ key = "tab", with = "control | shift", action = "ReceiveChar" },
	{ key = "[", with = "control | shift", action = "ReceiveChar" },
	{ key = "0", with = "control", action = "ReceiveChar" },
	{ key = "w", with = "control | shift", action = "ReceiveChar" },

	# Keybinds I actually want
	{ key = "c", with = "control | shift", action = "Copy" },
	{ key = "v", with = "control | shift", action = "Paste" },
	{ key = "=", with = "control", action = "IncreaseFontSize" },
	{ key = "-", with = "control", action = "DecreaseFontSize" },
	{ key = "n", with = "alt | shift", action = "CreateWindow" },
	{ key = "t", with = "alt", action = "CreateTab" },
	{ key = "1", with = "alt", action = "SelectTab(0)" },
	{ key = "2", with = "alt", action = "SelectTab(1)" },
	{ key = "3", with = "alt", action = "SelectTab(2)" },
	{ key = "4", with = "alt", action = "SelectTab(3)" },
	{ key = "5", with = "alt", action = "SelectTab(4)" },
	{ key = "6", with = "alt", action = "SelectTab(5)" },
	{ key = "7", with = "alt", action = "SelectTab(6)" },
	{ key = "8", with = "alt", action = "SelectTab(7)" },
	{ key = "9", with = "alt", action = "SelectTab(8)" },
	{ key = "0", with = "alt", action = "SelectTab(9)" },
	{ key = "pageup", with = "alt", action = "ScrollHalfPageUp" },
	{ key = "pagedown", with = "alt", action = "ScrollHalfPageDown" },
]

@raphamorim
Copy link
Owner

Hey @gplusplus314 thanks for the issue,

Could you remove these lines from your configuration and test again?

{ key = "c", with = "control | shift", action = "Copy" },
{ key = "v", with = "control | shift", action = "Paste" },

I suppose some keybindings are being processed twice since Copy and Paste (along with some in the list)

@Brianalmeida
Copy link
Sponsor Contributor

Brianalmeida commented Jan 17, 2024

Gave this a shot, and can't seem to reproduce this so far. Oddly, the behavior is the same as the default even when adding the keybindings to the config file

For reference, I am using:

  • Rio version 0.0.34
  • SLES 15 SP6

@TornaxO7
Copy link
Contributor

TornaxO7 commented Jan 20, 2024

Gave this a shot, and can't seem to reproduce this so far. Oddly, the behavior is the same as the default even when adding the keybindings to the config file

Just to avoid missunderstandings: So you did remove the copy+paste keybinding in your config.toml, right?

Because currently keybindings aren't overwriting the old ones! So make sure the copy+paste keybinding aren't in your config file otherwise they will be executed twice.

@Brianalmeida
Copy link
Sponsor Contributor

@TornaxO7 I added those bindings to my config, tested for a bit, then removed them (Commented them out) from my config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants