Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize evaluation module #166

Open
6 tasks
remrama opened this issue Apr 1, 2024 · 0 comments
Open
6 tasks

Finalize evaluation module #166

remrama opened this issue Apr 1, 2024 · 0 comments
Labels
enhancement 🚧 New feature or request

Comments

@remrama
Copy link
Collaborator

remrama commented Apr 1, 2024

A first draft has been merged, but some final upkeep needs to happen before yasa.evaluation is an official part of YASA.

  • Properly handle sleep statistics that are identical between scorers in SleepStatsAgreement
  • Add SleepStatsAgreement.plot_blandaltman
  • Add pytests
  • Update changelog
  • Review docstrings (especially the examples to make sure they did not fall behind code updates)
  • Add tutorial with sample data

I think that all those tasks are required except the Bland-Altman plots, which might be technically optional though strongly preferred. Also, they should be implemented without Pinguoin, as we've managed to avoid that dependency everywhere else, plus the Bland-Altman plots here will need to have additional flexibility anyways (e.g., to accommodate the regression-based measures).

Sidenote: I'm still not sure what the best way to validate this pipeline is, as I'm not aware of an existing (public) dataset that has ground-truth values.

@remrama remrama added the enhancement 🚧 New feature or request label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚧 New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant