Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Roof Types #40

Open
3 of 8 tasks
ranjian0 opened this issue Mar 17, 2020 · 7 comments
Open
3 of 8 tasks

New Roof Types #40

ranjian0 opened this issue Mar 17, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request Medium Priority Should be fixed when possible
Milestone

Comments

@ranjian0
Copy link
Owner

ranjian0 commented Mar 17, 2020

Task List:

  • Flat Roof.
  • Hip Roof.
  • Gable Roof.
  • Mansard Roof.
  • Gambrel Roof.
  • Dutch Hip.
  • Dutch Gable.
  • Rectilinear Roofing.

References:

Straight Skeleton Implementation
Petr Felkel and Stepan Obdrzalek
Automatically Generating Roof Models from Building Footprints
R. G. Laycock | robert.laycock@uea.ac.uk
A. M. Day | amd@sys.uea.ac.uk

This issue should track improvements and additions to the roof module and have the following images as guides.

Imgur
Imgur

Some issues that may need to be addressed first:

  • [SOLVED] Some roof types only work if the building floorplan has a particular shape, gable is a good example of this.
  • Roofs may also contain additional elements, the dormer roof in the first image is an example of this. Should the extra elements belong in the roof module or in another?
@ranjian0 ranjian0 added the enhancement New feature or request label Mar 17, 2020
@MarcusElg
Copy link
Collaborator

MarcusElg commented May 25, 2020

Some could probably be merged like gable and cross gable and also hip and crossod hip because they'll generate the same results depending on base shapes.

Would be nice if you could add dormers to any roof type.

@ranjian0 ranjian0 mentioned this issue May 27, 2020
@ranjian0
Copy link
Owner Author

New gable roof implementation with support for open gable and box gable for complex polygons is available in gable-roof-improvement branch.

Imgur

Some remaining issues are:

  • facemap generation
  • Extra/Duplicate geometry
  • Plus some yet undiscovered bugs as always.

@ranjian0
Copy link
Owner Author

Fixed remaining issues.
With #105 pending, improvements may be merged for 1.0 release.

@MarcusElg MarcusElg added the Medium Priority Should be fixed when possible label Jul 5, 2020
@Gadget2020
Copy link

All of the different roof styles could be boiled down to having an intermediate horizontal "loop-cut" around the roof and splitting it into an "upper" and "lower" section.

@thekaero
Copy link

Screenshot_114

Screenshot_115

Screenshot_111

Screenshot_112

Screenshot_113

@thekaero
Copy link

just dropping a comment for some ideas , good luck guys :)

@thekaero
Copy link

Screenshot_116

@ranjian0 ranjian0 added this to the 1.1 milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Medium Priority Should be fixed when possible
Projects
None yet
Development

No branches or pull requests

4 participants