Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Fill Types #39

Open
13 tasks
ranjian0 opened this issue Mar 17, 2020 · 7 comments
Open
13 tasks

Improved Fill Types #39

ranjian0 opened this issue Mar 17, 2020 · 7 comments
Labels
enhancement New feature or request High Priority Must be fixed soonest possible
Milestone

Comments

@ranjian0
Copy link
Owner

ranjian0 commented Mar 17, 2020

This issue is the base for work to begin on improving fill types. We would like to add a couple more fill types and also provide a set of quick presets for common fill types and/or combinations of fill types. The image references below should act as a guide.

Window

Imgur
Imgur

Door

Imgur

While there is no clear cut plan, the above images give a good indication of the direction we should be heading. New issues concerning this should refer here.

Task List:

  • Diamond
  • Cross Panel
  • Full Louver
  • Upper Louver
  • Lower Louver
  • Split Louver
  • Half Glass
  • Half Glass 1 panel
  • Half Glass 2 panel
  • Half Glass 3 panel
  • Half Glass 4 panel
  • Half Glass 2 panel horizontal
  • Half Glass 3 panel horizontal
@ranjian0 ranjian0 added the enhancement New feature or request label Mar 17, 2020
@MarcusElg
Copy link
Collaborator

Window boards would also be cool.

@ranjian0
Copy link
Owner Author

Window boards would also be cool.

Illustrations for this would be really handy. Just drop them here!

@MarcusElg MarcusElg added the Low Priority Not in a rush to fix label Jul 5, 2020
@ranjian0 ranjian0 added this to the 1.1 milestone Sep 28, 2020
@luckykadam
Copy link
Collaborator

It would be useful to have an option for bottom_panel in doors.

Behaviour:

  1. Enabling bottom panel will divide the door in two panels (height of bottom panel is configurable)
  2. Bottom panel can have its own fill type
  3. Use cases
    Top panel - glass panes, Bottom panel - panels
    Top panel - vertical panels, Bottom panel - horizontal panels

@ranjian0 What do you think ?

@ranjian0
Copy link
Owner Author

It would be useful to have an option for bottom_panel in doors.

Behaviour:

1. Enabling bottom panel will divide the door in two panels (height of bottom panel is configurable)

2. Bottom panel can have its own fill type

3. Use cases
   Top panel - glass panes, Bottom panel - panels
   Top panel - vertical panels, Bottom panel - horizontal panels

@ranjian0 What do you think ?

Yep. My thoughts exactly. Was just thinking of half fill feature similar to your idea. Configurable height is a really good option too.

@ranjian0 ranjian0 added Medium Priority Should be fixed when possible and removed Low Priority Not in a rush to fix labels Dec 15, 2020
@MarcusElg
Copy link
Collaborator

It would be useful to have an option for bottom_panel in doors.
Behaviour:

1. Enabling bottom panel will divide the door in two panels (height of bottom panel is configurable)

2. Bottom panel can have its own fill type

3. Use cases
   Top panel - glass panes, Bottom panel - panels
   Top panel - vertical panels, Bottom panel - horizontal panels

@ranjian0 What do you think ?

Yep. My thoughts exactly. Was just thinking of half fill feature similar to your idea. Configurable height is a really good option too.

I agree, the question is how flexible the system should be, either you just allow having two sections or you allow it to be any numbers. If you had two panels wide and 4 panels high then you could create the 8 panel door from the picture, just something to think about

@ranjian0
Copy link
Owner Author

ranjian0 commented Dec 15, 2020

I think two should be enough. If more is needed, we can implement it in such a way that fills can be added recursively. e.g
You make an initial fill with two sections but leave one of them empty and then use the fill tool again on the empty section.

Possibilities are endless.

@MarcusElg
Copy link
Collaborator

I think two should be enough. If more is needed, we can implement it in such a way that fills can be added recursively. e.g
You make an initial fill with two sections but leave one of them empty and then use the fill tool again on the empty section.

Possibilities are endless.

Thats really smart, typical situation of when you can simply things as its in blender :P As long as you can change where the door/window divides and if it should be done vertically or horizontally then you could do anything

@ranjian0 ranjian0 added High Priority Must be fixed soonest possible and removed Medium Priority Should be fixed when possible labels Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request High Priority Must be fixed soonest possible
Projects
None yet
Development

No branches or pull requests

3 participants