Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Balcony Features #166

Open
1 of 6 tasks
LinkinJX opened this issue Sep 26, 2020 · 17 comments
Open
1 of 6 tasks

Extra Balcony Features #166

LinkinJX opened this issue Sep 26, 2020 · 17 comments
Assignees
Labels
enhancement New feature or request Medium Priority Should be fixed when possible
Milestone

Comments

@LinkinJX
Copy link

LinkinJX commented Sep 26, 2020

I wonder if it's possible to implement an option to add balconies along horizontaly adjacent faces like corners and curves.

  • Balcony on adjacent faces
    Curved Balcony

Some more ideas about balconies:

  • Beveled posts and rails
    image

  • Columns for the corners
    image

  • Separation walls between adjacent balconies
    image

  • Depth of the Balcony similar to "Frame Depth" for windows and doors
    image

  • Curved Balconies, suggested by @ranjian0
    image

Thank you all for your amazing work!

@LinkinJX LinkinJX added the enhancement New feature or request label Sep 26, 2020
@LinkinJX LinkinJX changed the title Curved and Corner Balcony Curved and Corner Balcony, and other requests Sep 26, 2020
@MarcusElg
Copy link
Collaborator

MarcusElg commented Sep 26, 2020

We have discussed being able to add railings to any plane so the logical way to do your request would be to first extrude the edges outwards, then extrude them up and finally add the railing. Someone needs to implement it tho 🤷🏻‍♂️

@ranjian0 ranjian0 self-assigned this Sep 26, 2020
@ranjian0
Copy link
Owner

ranjian0 commented Sep 26, 2020

Some more ideas about balconies:

  • Beveled posts and rails
  • Columns for the corners
  • Separation walls between adjacent balconies

I would very much appreciate images of what you mean for the above ideas.

As for your other request, adding balconies on adjacent horizontal faces should be doable even when edges are curved. The only issue would be how to differentiate the different kinds of selection a user can have. I will try to get this working over the weekend, should not be too complicated.

The other ideas will probably need more time.

@LinkinJX
Copy link
Author

Thanks for your replies, I will add images to the original comment to illustrate what I mean

@LinkinJX
Copy link
Author

I have some more ideas related to balconies, is it ok if I continue adding them in my first comment to keep it organized, or is it better to add them in a new one?

@ranjian0
Copy link
Owner

If it is related to balconies it's ok. You should also rename the issue to something more suitable.

@LinkinJX LinkinJX changed the title Curved and Corner Balcony, and other requests Extra Balcony Features Sep 27, 2020
@LinkinJX
Copy link
Author

Done. Feel free to rename it if you find a more adequate name.

@ranjian0
Copy link
Owner

Ok. I am still figuring out how to get balcony on adjacent faces. Not quite as trivial as I had hoped but I am halfway through. I am curious about how you got the bevels on the posts. Could you send a screenshot with the options?

@LinkinJX
Copy link
Author

I beveled the top and bottom edges of the rail using a custom profile
image

Another option is to use a Bevel modifier using a Vertex Group as Limit Method
image
I used Cornice Moulding as Preset for the Custom Profile

@MarcusElg
Copy link
Collaborator

MarcusElg commented Sep 28, 2020

Beveling the top and bottom edges feels like the better way of the two to implement it

@ranjian0
Copy link
Owner

balcony2-2020-09-28-213544

Balconies on adjacent faces is almost done. Just a few more kinks to iron out. When adding to curved walls like your first illustration, corner posts don't have the correct rotation.

DeepinScreenshot_select-area_20200928215855

I will probably also add this feature to the stairs module too.
This was a very nice feature request, got me re-energised on development.

@ranjian0
Copy link
Owner

ranjian0 commented Sep 28, 2020

Curved balconies like in the picture below.

curved balcony ex

@ranjian0 ranjian0 added the Medium Priority Should be fixed when possible label Sep 28, 2020
@MarcusElg
Copy link
Collaborator

balcony2-2020-09-28-213544

Balconies on adjacent faces is almost done. Just a few more kinks to iron out. When adding to curved walls like your first illustration, corner posts don't have the correct rotation.

DeepinScreenshot_select-area_20200928215855

I will probably also add this feature to the stairs module too.
This was a very nice feature request, got me re-energised on development.

That's really cool!

@LinkinJX
Copy link
Author

balcony2-2020-09-28-213544

Balconies on adjacent faces is almost done. Just a few more kinks to iron out. When adding to curved walls like your first illustration, corner posts don't have the correct rotation.

DeepinScreenshot_select-area_20200928215855

I will probably also add this feature to the stairs module too.
This was a very nice feature request, got me re-energised on development.

Is it possible to disable intermediate corner posts somehow?
What I mean by intermediate corner posts:
image
Looking awesome anyway!

@ranjian0
Copy link
Owner

Currently its only possible to remove intermediate posts if they are between two parallel sections but this can easily be extended to sections that don't have a right angle. Maybe we can add a threshold option for this.

@LinkinJX
Copy link
Author

LinkinJX commented Oct 1, 2020

The more I use the addon, the more potential I see in it. I think I'll open another Issue with some general ideas that I'm having all the time.

@MarcusElg
Copy link
Collaborator

The more I use the addon, the more potential I see in it. I think I'll open another Issue with some general ideas that I'm having all the time.

Open seperate issues if the ideas aren't really related

@LinkinJX
Copy link
Author

LinkinJX commented Oct 1, 2020

Various of the ideas are similar changes to multiple modules, that's why I think it might be better to group some of them.

@ranjian0 ranjian0 added this to the 1.1 milestone Dec 15, 2020
@ranjian0 ranjian0 mentioned this issue Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Medium Priority Should be fixed when possible
Projects
None yet
Development

No branches or pull requests

3 participants