Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in the time_actions table, there is an issue with how tokens being used in tokenswap contract are being stored. Fix this #32

Open
vivekteega opened this issue May 9, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@vivekteega
Copy link
Member

They aren't being stored like a list ['bioscope', 'rupee']

@vivekteega vivekteega self-assigned this May 9, 2023
@vivekteega vivekteega added the enhancement New feature or request label May 9, 2023
@vivekteega
Copy link
Member Author

Upon investigation :

In contracts of the type where there is a time action created during the contract creation itself (one-time-event external trigger | one-time-event time trigger), the tokens are stored as a list.

In contracts of the type where the time actions are not defined during the creation of the contract but are defined upon further participation in the contract( continuous event token swap), the tokens_db column is filled depending upon the action being performed.
For eg. In a token swap contract, deposits are time-related actions. For a deposit, there is only 1 associated token during the transaction( the token being deposited). Hence it is being entered without a list.


  • Until now, the contracts which are being added to time_actions table during the creation itself fall under the categories where only a single token is present. Do we keep it as a list or change it to normal single entry without the list?
  • Should all tokenIdentification & token_db columns be stored as lists so it is same across all the devices?

@vivekteega vivekteega added the help wanted Extra attention is needed label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant