Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External trigger committee addresses should shift to blockchain #13

Open
vivekteega opened this issue Nov 15, 2022 · 2 comments
Open

External trigger committee addresses should shift to blockchain #13

vivekteega opened this issue Nov 15, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@vivekteega
Copy link
Member

Current external trigger committee address is part of the config.ini file. This has to be moved such that the committee address is fetched from the blockchain

@vivekteega vivekteega self-assigned this Nov 15, 2022
@vivekteega vivekteega added the enhancement New feature or request label Jan 24, 2023
@vivekteega
Copy link
Member Author

Commit - 528223f

Shifted the committee address to external trigger. The app will have an Admin FLO ID which can add or remove committee members for the smart contracts

@vivekteega
Copy link
Member Author

vivekteega commented Feb 16, 2023

Remaining issues

  • e599caa - Contract committee list calculation should only consider transactions whose input address is the admin FLO address
  • acffba0 - Add functionality to remove a committee member from the list based on the time. Its possible that a committee member provided the right triggers for x number of contract before going rogue. Removal of the committee member after going rogue should not affect the previous contract's results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant