Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose one source for pulling CNI plugins #3327

Open
manuelbuil opened this issue Aug 4, 2023 · 1 comment
Open

Choose one source for pulling CNI plugins #3327

manuelbuil opened this issue Aug 4, 2023 · 1 comment
Assignees

Comments

@manuelbuil
Copy link
Contributor

manuelbuil commented Aug 4, 2023

CNI plugin binaries are being pulled in three different places:

1 - In hyperkube-base: https://github.com/rancher/hyperkube-base/blob/master/Makefile#L30-L32
2 - In rke-tools: https://github.com/rancher/rke-tools/blob/master/package/Dockerfile#L25-L27
3 - CNI plugins include logic to distribute CNI plugin binaries too (not clear about Weave though)

We should investigate why but I suspect it is just a mistake. In that case, we should decide on one (probably 3), verify that things work and remove the rest

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant