Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Support certificate chains when using custom certs. #3213

Conversation

TheSp1der
Copy link

@TheSp1der TheSp1der commented Apr 6, 2023

This PR is a duplicate of PR #2742 but directed to the 1.4 release branch. This closes #3083.

I can not take credit for the original work for this pull request which was completed by chaudhryfaisal.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

@TheSp1der
Copy link
Author

This pull request is still valid.

Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiaqiluo jiaqiluo requested a review from a team June 15, 2023 18:29
pki/util.go Show resolved Hide resolved
@jiaqiluo jiaqiluo changed the title Support certificate chains when using custom certs. [DNM] Support certificate chains when using custom certs. Jun 21, 2023
@jiaqiluo
Copy link
Member

jiaqiluo commented Jun 21, 2023

Do not merge the PR until the REK v1.4.6 is released.

@github-actions
Copy link
Contributor

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

@TheSp1der
Copy link
Author

Can this still be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.4] Support certificate chains when using custom certs
3 participants