Add support for iface-regex options in flannel/canal

[germanoeich]

flanneld has support for the iface-regex option, but this is not available in the rancher network config options. This forces operators to either modify the DaemonSet manually, which is very fragile, or enforce a consistent interface name across all nodes within the cluster, which may not always be feasible and is error prone.

This has been asked multiple times:
#2577 - Marked as stale and closed
rancher/rancher#17180 - Opened since 2018

Can I get a confirmation on if you plan to support this and/or if you would accept PRs relating to this?

[steve-todorov]

Yes! YES PLEASE!!!!

I have a custom bash script which starts rke and then does a very nasty patch to fix some issues:

  echo "Patch flannel deployment to add iface-regex so it uses the correct interfaces for flannel external traffic"  > /dev/null
  IFACE1_REGEX="192\.0\.0\.*"
  IFACE2_REGEX="192\.8\.1\.*"
  (kubectl get daemonsets.apps --namespace=kube-system canal -o yaml | yq e '(.spec.template.spec.containers.[] | select(.name == "kube-flannel")).command |= ["/opt/bin/flanneld", "--ip-masq", "--kube-subnet-mgr", "--iface-regex='$IFACE1_REGEX'", "--iface-regex='$IFACE2_REGEX'"]' - | kubectl apply -f -)

It would make my life so much, much, MUCH easier if there was an option you could put in the services section that would ... maybe something like:

network:
  plugin: canal
  options:
    flannel_backend_type: vxlan
    flannel_iface: flannel.1
    flannel_iface_regex: [ "192\.0\.0\.*", "192\.8\.1\.*", ... ]

[github-actions]

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

[steve-todorov]

Still relevant.

[github-actions]

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

[germanoeich]

Still relevant

[steve-todorov]

@ibuildthecloud sorry for tagging you directly, but it looks like this issue (as well as rancher/rancher#17180) have been under the radar for more than 4 years now. Are there any plans to add this simple improvement?

Unfortunately Go lang is not my area of expertise, otherwise I would have opened a PR a long time ago.

[github-actions]

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

[steve-todorov]

Still relevant. :)

[aimbot31]

still

[steve-todorov]

Relevant.

[github-actions]

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

[steve-todorov]

Still

[github-actions]

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

[steve-todorov]

Not stale.

[github-actions]

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

[steve-todorov]

Bump.

[github-actions]

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

[steve-todorov]

Still relevant.

[github-actions]

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

[steve-todorov]

Lol... still relevant :D

[manuelbuil]

hey, RKE2 engineer here. We have this feature ready in RKE2 if you would consider using RKE2 instead: https://github.com/rancher/rke2-charts/blob/main-source/packages/rke2-canal/charts/values.yaml#L15

[github-actions]

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.