-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add data directory
configuration component to advanced tab in rke2 create/edit cluster interface
#11039
add data directory
configuration component to advanced tab in rke2 create/edit cluster interface
#11039
Conversation
28c19e4
to
e458151
Compare
shell/edit/provisioning.cattle.io.cluster/__tests__/DirectoryConfig.test.ts
Outdated
Show resolved
Hide resolved
shell/edit/provisioning.cattle.io.cluster/tabs/DirectoryConfig.vue
Outdated
Show resolved
Hide resolved
…eate/edit cluster interface + add unit test
e458151
to
d4ea7dd
Compare
I removed the optional chaining before (I agree it should not be needed) but this caused failures in at least another unit test... I just re-added them to move this forward :P |
It seems you can fix all those failing tests by adding:
to: |
…face) + adjust unit tests
@momesgin code updated 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I am getting found in ---> at shell/edit/provisioning.cattle.io.cluster/tabs/DirectoryConfig.vue Screen.Recording.2024-05-24.at.2.47.13.PM.mov |
Gm @eva-vashkevich . This was dependent on a backend issue rancher/rancher#45038 but all of the work has been merged, afaik. I am going to give this a test with a new backend image. Since I've done the frontend part without the backend being finished, I totally forgot to test it manually and merged this (all based on the RFC doc). 🙏 |
Looking at the associated PRs, I don't think the backend part is completed to this date.... 🤔 The console message is not pretty, but I don't think there's a high risk with the current work merged. It allows for creating/edit of a cluster + the console message doesn't appear unless you're running the UI locally. I've just pinged the backend team to get more information about the current status of their work and it's expected to be completed. |
@aalves08 Thank you for looking into it |
Summary
Fixes #10824
Occurred changes and/or fixed issues
data directory configuration
component to advanced tab in rke2 create/edit cluster interfacedata directory configuration
componentTechnical notes summary
Areas or cases that should be tested
data configuration
area is present on theAdvanced
tab of Cluster Configurationdata configuration
is disabled (not allowed to change the values)Areas which could experience regressions
Screenshot/Video
NOTE: this video still doesn't cover the edit scenario properly, since we still don't have the changes needed on the backend to persist the data, but it proves the payload sent is correct
Screen.Recording.2024-05-16.at.12.28.21.mov
Checklist