Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two1 dependency #49

Open
amiraliakbari opened this issue Jun 25, 2020 · 3 comments
Open

Remove two1 dependency #49

amiraliakbari opened this issue Jun 25, 2020 · 3 comments

Comments

@amiraliakbari
Copy link

The two1 library required in this package has been inactive for 3 years and has issues (like 21dotco/two1-python#29) that causes problems for projects using it.

As far as I checked, the dependency on two1 is limited to a few functions. If you confirm, I can provide the pull request for inlining those needed functions in pywallet code?

@Tydus
Copy link

Tydus commented Feb 18, 2021

+1

Particularly, two1 itself depends on sha256, which is even older. It can no longer be built since Python 3.9, thus causes a fatal issue blocks pip installing pywallet.

@sech444
Copy link

sech444 commented Apr 3, 2022

ERROR: Cannot install ing==0.1.0, pywallet and pywallet==0.0.1 because these package versions have conflicting dependencies.
when is use, pip install ing pywallet i still the following come conflict

The conflict is caused by:
pywallet 0.0.1 depends on base58==0.2.1
two1 3.10.9 depends on base58==0.2.2
ing 0.1.0 depends on click<8.0 and >=7.0
two1 3.10.8 depends on click==6.6

To fix this you could try to:

  1. loosen the range of package versions you've specified
  2. remove package versions to allow pip attempt to solve the dependency conflict

then I get this error
from pywallet import wallet
ModuleNotFoundError: No module named 'pywallet'

if I use pip install pywallet
then if I use pip check i get the following error

web3 5.28.0 has requirement requests<3.0.0,>=2.16.0, but you have requests 2.11.1.
uvicorn 0.17.5 has requirement click>=7.0, but you have click 6.6.
shrimpy-python 0.0.15 has requirement requests>=2.13.0, but you have requests 2.11.1.
flask 2.1.1 has requirement click>=8.0, but you have click 6.6.
docker 5.0.3 has requirement requests!=2.18.0,>=2.14.2, but you have requests 2.11.1.
bitcoinlib 0.6.4 has requirement requests>=2.25.0, but you have requests 2.11.1.
please how can solve this problem ??

@ZenulAbidin
Copy link

ZenulAbidin commented May 12, 2023

Just use my fork https://guthub.com/ZenulAbidin/zpywallet , I have eliminated the two1 dependency inside it. It's largely useless anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants