ValueExtractorTrait does not extract from public methods with same name as private properties

[fvdb]

Description

When AbstractCollection contains objects which have both a method and property with the same name, the value can never be extracted from the method through ValueExtractorTrait::extractValue().

Steps to reproduce

class Person
{
    public function __construct(private string $name)
    {
    }

    public function name(): string
    {
        return $this->name;
    }
}

$collection = new Ramsey\Collection\Collection();
$collection->add(new Person('Bob'));

print_r($collection->columns('name'));

The above triggers an error:

Error: Cannot access private property Person::$name

Expected behavior

Array
(
    [0] => Bob
)

Environment details

• version of this package: 2.0.0
• PHP version: 8.2.5

Cause

This seems to be because ValueExtractorTrait::extractValue() does not check if the property is actually accessible before trying to access it. It then proceeds to access it, causing the error, and then it never gets to checking whether a method exists with that same name which actually is accessible.

Possible solutions

One option would be to verify accessibility before attempting to access the property or method, but this would require use of reflection with obvious performance downsides.

Alternatively if it is detected that both the method and property exist of the same name, one could use a try/catch block to attempt to access them and then only throw an exception if both attempts failed.

Finally another "fix" could be to swap the position of accessing the property with that of accessing the method, which would work for the above use case (which is probably the most common). However, this would then cause a similar issue for objects with a private method and public property with the same name.