Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptions on photos (?) #11

Open
samcolby opened this issue Dec 9, 2017 · 2 comments
Open

Descriptions on photos (?) #11

samcolby opened this issue Dec 9, 2017 · 2 comments
Assignees

Comments

@samcolby
Copy link
Contributor

samcolby commented Dec 9, 2017

Hi,

I'm thinking of adding the ability to add some text descriptions to each photo. Do you have any thoughts on this?

I was thinking of, but not really checked what is possible with Jekyll and the lightbox you are using.

  • Another file named the same as the full/image file that contains the html to display
  • If this new file exists, then display first line or 2 of the text on top of the image (similar to how the exif data is displayed)
  • When opened in the lightbox, display all of the text details under the image.

Just looking for feedback on this, before I start to tinker around with it.

Sam

@rampatra
Copy link
Owner

rampatra commented Dec 9, 2017

Hi, I thought of this earlier while making this jekyll template but I had a motive in mind that photographers shouldn't have to fill in stuff in order to upload their work. Having said that, your approach won't bound them to provide a description but rather make it optional which is good. So, we can definitely have such a feature but I would prefer to show only images in the tiles view and show the description when opened in the lightbox only.

This lightbox used here is poptrox with a slight modification which I made for exif data. This library shows the caption/description on top of the image instead of at the bottom. See index.html where I have commented out the lines which was meant for caption:

<!--<h2></h2>
<p></p>-->

@samcolby
Copy link
Contributor Author

Ah, I did wonder what the commented out html was for !

You modified poptrox to add the caption callback? It looks like we'd need further poptrox modifications to display the descriptions too. poptrox doesn't look like it is being maintained any more either, so this will become your fork in effect.

I have some long flights this week, so I can try and take a look then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants