Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream plugin update notification #271

Open
kelteseth opened this issue Apr 29, 2024 · 1 comment
Open

Upstream plugin update notification #271

kelteseth opened this issue Apr 29, 2024 · 1 comment
Labels
editor enhancement New feature or request

Comments

@kelteseth
Copy link

kelteseth commented Apr 29, 2024

Project Type

Editor

Feature Description

The idea of having a notification is cool, but has some flaws:

  • Now every team member asks me "What should I click" when the update message appears. After every update.
  • This should be more like in the warnings tab of the editor that your plugin is outdated
  • It would be cool to have this feature upstream as a regular Godot feature. It would be bad if now every Godot plugin starts creating their own updater...

👋

Use Cases

(Optional) Proposed Solution

No response

@ramokz
Copy link
Owner

ramokz commented Apr 29, 2024

Now every team member asks me "What should I click" when the update message appears. After every update.

That is the intent behind the ability to disable the updater prompt for the setting, so you can turn it off if you would rather not see it when it occurs.
The challenge is to avoid obfuscating that there is an update, as fixes and improvements go in. But to your point, it can also become a distracting if you aren't concerned about updates at certain stages.

This should be more like in the warnings tab of the editor that your plugin is outdated

The current updater is based on the editor from dialogue_manager addon, so it follows most of the same logic as the one there. Haven't explored that idea of applying it to the tab, but think it's a sound suggestion. Would imagine it would be simple to change, but will need to look into it when time allows. If you've got any pointers to it, then that would be very welcome!

It would be cool to have this feature upstream as a regular Godot feature. It would be bad if now every Godot plugin starts creating their own updater...

There is a Godot proposal for this, but it's a complicated thing that's still being figured out.

@ramokz ramokz added enhancement New feature or request editor labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants