Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all spring arm initializaiton code out of _process into _ready #282

Merged
merged 6 commits into from May 2, 2024

Conversation

ZenithStar
Copy link
Contributor

Resolves #193

Copy link
Owner

@ramokz ramokz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works well for me!

Only a few nitpicks, doesn't alter the result, but it keeps the property assignment consistent.

@ZenithStar ZenithStar requested a review from ramokz May 2, 2024 13:01
Copy link
Owner

@ramokz ramokz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Agree with your comments.

Also closes #233.

@ramokz ramokz changed the base branch from main to 0.7.1 May 2, 2024 20:55
@ramokz ramokz merged commit 95f8e14 into ramokz:0.7.1 May 2, 2024
@ramokz
Copy link
Owner

ramokz commented May 2, 2024

Thanks for the PR and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants