Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor icons appear small on high DPI screens #155

Open
ramokz opened this issue Dec 22, 2023 · 2 comments
Open

Editor icons appear small on high DPI screens #155

ramokz opened this issue Dec 22, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed Investigating

Comments

@ramokz
Copy link
Owner

ramokz commented Dec 22, 2023

Issue description

When installing the addon via the AssetLib, within the Godot Editor, the editor will crash upon completion. This only happens once right after installation, where the addon will work correctly after restarting the editor.

This appears to only happen when installing it via the AssetLib, and not when manually importing the addon from a GitHub release.

Additionally, the images marked with Scale With Editor Scale enabled will spam the editor saying Missing required editor-specific import metadata for a texture (please reimport it using the 'Import' tab) [...]

Thanks to Bissash for report.

Steps to reproduce

  1. Open a Godot project where the Phantom Camera addon isn't installed.
  2. Open the AssetLib tab
  3. Find and install Phantom Camera
  4. Upon installation, the editor crashes and/or produces the import errors

(Optional) Minimal reproduction project

No response

@ramokz ramokz added bug Something isn't working help wanted Extra attention is needed Investigating labels Dec 22, 2023
@ramokz ramokz pinned this issue Dec 22, 2023
@ramokz ramokz changed the title Crash after AssetLib installation Crash after AssetLib installation and image import errors Dec 22, 2023
@ramokz
Copy link
Owner Author

ramokz commented Dec 22, 2023

This appears to be the same issue as in godotengine/godot#85859.
The crash and import errors might be related, but it's difficult to tell at this stage.

A fix should be coming in Godot 4.3 for the assets at the very least.

@ramokz ramokz changed the title Crash after AssetLib installation and image import errors Editor icons appear small on high DPI screens Jan 9, 2024
@ramokz
Copy link
Owner Author

ramokz commented Jan 9, 2024

Will keep icons small for the time being until at minimum Godot 4.3 is released to avoid the various issues lised above. After that, can revisit when it would be appropriate to provide better icon support for high DPI displays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed Investigating
Projects
None yet
Development

No branches or pull requests

1 participant