Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect link names in additionals #70

Open
dersnek opened this issue Feb 23, 2019 · 3 comments
Open

Incorrect link names in additionals #70

dersnek opened this issue Feb 23, 2019 · 3 comments

Comments

@dersnek
Copy link

dersnek commented Feb 23, 2019

Filling additionals menu as in manual, shows link names as "http:" instead of domain name.

Code in data.xml:

<additional>
    <title>Katata Blog</title>
    <description>We're keeping a record of our struggles as game developers</description>
    <link>http://katatagames.com/category/blog</link>
</additional>

Expected result:
We're keeping a record of our struggles as game developers katatagames.com.
(where "katatagames.com" is a link to http://katatagames.com/category/blog)

Actual result:
We're keeping a record of our struggles as game developers http:.
(where "http:" is a link to http://katatagames.com/category/blog)

Examples:
http://katatagames.com/press/
https://www.vlambeer.com/press/

Examples without bug:
http://younghorsesgames.com/press/sheet.php?p=octodad_dadliest_catch
http://press.headbang.club/sheet.php?p=double_kick_heroes

@mbndr
Copy link

mbndr commented Feb 24, 2019

I guess you have to fix the bug yourself because this repository seems abandoned (last commit 2014). The error has to be somewhere around here or more likely here.

If you want (and are a bit experienced in Go compiling) you could also check out my Go rewrite where I can help you more. (https://github.com/mbndr/gopresskit)

@dersnek
Copy link
Author

dersnek commented Feb 24, 2019

I guess you have to fix the bug yourself because this repository seems abandoned (last commit 2014). The error has to be somewhere around here or more likely here.

If you want (and are a bit experienced in Go compiling) you could also check out my Go rewrite where I can help you more. (https://github.com/mbndr/gopresskit)

Should've thought about that. Thanks, I'll try to fix it or I'll try your rewrite. I'm not experienced in Go compiling but maybe it's time to give it a try.

@qulien
Copy link

qulien commented Dec 16, 2021

Link handling is an inconsistent, buggy mess. It really is. Sometimes "http://" will be added. Sometimes not. Sometimes a "/" gets added at the end. Or removed from the end. Sometimes not.

This inconsistency shows in obvious ways, for example the broken link text you found. But it also shows in other, less visible places. For example, you can see on the Vlambeer example presskit page that the company link in the "Factsheet" section actually looks like this (note the double "https://"):

<a href="http://http://www.vlambeer.com">http://www.vlambeer.com</a>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants