Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't install Linenoise on Windows #29

Open
Prince213 opened this issue Nov 16, 2019 · 19 comments
Open

can't install Linenoise on Windows #29

Prince213 opened this issue Nov 16, 2019 · 19 comments

Comments

@Prince213
Copy link
Contributor

Hi, I'm trying to install Linenoise with zef, and got a warning similar with #25:

zef install Linenoise
===> Searching for: Linenoise
===> Updating cpan mirror: https://raw.githubusercontent.com/ugexe/Perl6-ecosystems/master/cpan1.json
===> Updating p6c mirror: https://raw.githubusercontent.com/ugexe/Perl6-ecosystems/master/p6c1.json
===> Updated p6c mirror: https://raw.githubusercontent.com/ugexe/Perl6-ecosystems/master/p6c1.json
===> Updated cpan mirror: https://raw.githubusercontent.com/ugexe/Perl6-ecosystems/master/cpan1.json
===> Searching for missing dependencies: LibraryMake
===> Searching for missing dependencies: Shell::Command
===> Searching for missing dependencies: File::Which, File::Find
===> Building: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Building [OK] for Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Testing: File::Which:ver<1.0.1>
[File::Which] # Found perl6 at 'D:\perl\bin\perl6.EXE'
[File::Which] # Found perl6 at 'D:\perl\bin\perl6.EXE' using whence     
===> Testing [OK] for File::Which:ver<1.0.1>
===> Testing: File::Find:ver<0.1>
===> Testing [OK] for File::Find:ver<0.1>
===> Testing: Shell::Command
===> Testing [OK] for Shell::Command
===> Testing: LibraryMake:ver<1.0.0>:auth<github:retupmoca>
===> Testing [OK] for LibraryMake:ver<1.0.0>:auth<github:retupmoca>     
===> Testing: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Testing [OK] for Linenoise:ver<0.1.1>:auth<Rob Hoelz>
===> Installing: File::Which:ver<1.0.1>
===> Installing: File::Find:ver<0.1>
===> Installing: Shell::Command
===> Installing: LibraryMake:ver<1.0.0>:auth<github:retupmoca>
===> Installing: Linenoise:ver<0.1.1>:auth<Rob Hoelz>
Use of Nil in string context
  in block  at site#sources\0BDF8C54D33921FEA066491D8D13C96A7CB144B9 (Linenoise) line 15

When I run REPL, this warning is emitted:

I ran into a problem while trying to set up Linenoise: Must specify something as a path: did you mean '.' for the current directory?
Continuing without tab completions or line editor
You may want to consider using rlwrap for simple line editor functionality

To exit type 'exit' or '^Z'
>

Environment:
zef version: v0.8.2
Rakudo version:

This is Rakudo version 2019.07.1-478-g75056dfa1 built on MoarVM version 
2019.07.1-309-g48491b896
implementing Perl 6.d.
@hoelzro
Copy link
Collaborator

hoelzro commented Nov 16, 2019

Hello,

I've stopped working on this library - I recommend reaching out to the fine folks at #raku on IRC and seeing if they can help you out!

@JJ
Copy link
Collaborator

JJ commented Nov 16, 2019

If that's the case, maybe you can give someone else privileges to keep working on this? This is still part of Rakudo Star (until, probably, next release)

@hoelzro
Copy link
Collaborator

hoelzro commented Nov 17, 2019

@JJ Sure, I'd be happy to! How do you feel about me transfering ownership to the perl6 organization?

@Prince213
Copy link
Contributor Author

@hoelzro It will be great if this library continues to be maintained as Readline is too big for command line editing and requires a lot of efforts to make it work on Windows.

@JJ
Copy link
Collaborator

JJ commented Nov 17, 2019

@hoelzro if there's not anyone else wanting to co-maintain it, we could transfer it to perl6-community-modules

@Prince213
Copy link
Contributor Author

@JJ Good idea. It's really important for editing experience.

@hoelzro
Copy link
Collaborator

hoelzro commented Nov 17, 2019

Sounds good - consider it done!

@hoelzro
Copy link
Collaborator

hoelzro commented Nov 17, 2019

Ok...I tried, but GitHub tells me I lack the permissions to create public repositories on perl6-community-modules =/

@Prince213
Copy link
Contributor Author

@hoelzro I guess you need be a member of perl6-community-modules first. Maybe you should connect someone in perl6-community-modules.

@JJ
Copy link
Collaborator

JJ commented Nov 17, 2019 via email

@hoelzro
Copy link
Collaborator

hoelzro commented Nov 17, 2019

@JJ Sounds good - do I just add you as a co-maintainer, then?

@JJ
Copy link
Collaborator

JJ commented Nov 17, 2019 via email

@hoelzro
Copy link
Collaborator

hoelzro commented Nov 17, 2019

@JJ Ok, you should have an invite to be a collaborator now. I'd prefer if the repo were moved under the perl6 umbrella, just so there's no confusion about my ability to contribute fixes in the future!

@JJ
Copy link
Collaborator

JJ commented Nov 17, 2019 via email

@JJ
Copy link
Collaborator

JJ commented Nov 18, 2019

This is line 15:

    my constant LIBLINENOISE = %?RESOURCES<libraries/linenoise>.Str;

I think it's simply failing to find the library in Windows. I guess this can be fixed with instructions, more than any other thing...

@JJ
Copy link
Collaborator

JJ commented Nov 18, 2019

From here: antirez/linenoise#113 it looks line the underlying linenoise library does not work in Windows, and has apparently never had. The issue selects several alternatives, mostly written in C++, which are also mentioned in this README.md. The problem is that I have no idea if the library itself is compatible; also, C++ and the Native interface are probably not a good mix... So I don't see an easy solution for this.

@JJ
Copy link
Collaborator

JJ commented Nov 18, 2019

OK, so it might be fixable after all, according to #17. But you'll need to use mingw.

@hoelzro
Copy link
Collaborator

hoelzro commented Nov 19, 2019

@JJ The linenoise code in this repo is actually from a MoarVM-based fork (see 72003ff) that supports Windows - I'm guessing the use of %?RESOURCES needs to change. You might find d0a2ec0 and f368fe0 useful to look at for ideas

@JJ
Copy link
Collaborator

JJ commented Nov 19, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants