Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to merge in UTF-8 supporting fork of Linenoise into our version? #20

Open
samcv opened this issue Apr 24, 2017 · 10 comments
Open

Able to merge in UTF-8 supporting fork of Linenoise into our version? #20

samcv opened this issue Apr 24, 2017 · 10 comments

Comments

@samcv
Copy link
Contributor

samcv commented Apr 24, 2017

See here:
https://github.com/yhirose/linenoise/tree/utf8-support

Would be great if we had UTF-8 support for this, as it's really an issue especially for a programming language that can use Unicode characters.

@hoelzro
Copy link
Collaborator

hoelzro commented Apr 26, 2017

UTF-8 support would be fantastic! I worked on this a little bit last year, but I don't remember which stumbling blocks I encountered that prevented me from finalizing the work. I'm on vacation right now, but I'll have a look after I get back.

@hoelzro
Copy link
Collaborator

hoelzro commented Apr 26, 2017

Another fork worth looking at: https://github.com/arangodb/linenoise-ng

@hoelzro
Copy link
Collaborator

hoelzro commented Apr 26, 2017

@hoelzro
Copy link
Collaborator

hoelzro commented Apr 26, 2017

(Note to self: look at journal entries for late March/early April 2016)

@hoelzro
Copy link
Collaborator

hoelzro commented May 4, 2017

Another fork to consider incorporating (not UTF-8 related, but still): antirez/linenoise#113

@samcv
Copy link
Contributor Author

samcv commented May 4, 2017

linenoise-ng supposedly has Windows support. That would be really awesome :) Then we can support UTF-8 and all operating systems!

hoelzro added a commit that referenced this issue May 7, 2017
Provides Windows and UTF-8 support

There's some GCC-specific flags in Makefile.in, so this isn't suitable
for Windows installation yet

See GH #20
@hoelzro
Copy link
Collaborator

hoelzro commented May 7, 2017

@samcv I added support in the multi-byte branch - I can't merge this until LibraryMake provides a C++ equivalent to CC and other Makefile.in variables, though. I'm currently using some GCC-specific build flags to get it working on Linux, but it won't work on Windows (unless GCC is used there too)

@mcreenan
Copy link

mcreenan commented Sep 6, 2018

Are the requirements from LibraryMake available now?

If not, how can I point my project to use the multi-byte version of this? I've tried to clone the repository and build it myself, but there are no "build from source" instructions and I was unable to figure it out on my own.

Thanks!

@hoelzro
Copy link
Collaborator

hoelzro commented Sep 7, 2018

@mcreenan I just took a quick look at the LibraryMake source - from what I can tell, sadly, that information is still not available =(

If you're using GCC, cloning the repository and doing a zef install . should just work - let me know if it doesn't. If you're willing to put in the time, the C++ code could be ported to straight up C, and then I could merge the branch into master!

@mcreenan
Copy link

mcreenan commented Sep 7, 2018

Ah. zef install . did work after I uninstalled the published version. Thanks!

I'll look into porting, but I haven't done C or C++ in 10+ years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants