Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new release? #1272

Open
loskutov opened this issue Apr 29, 2024 · 3 comments
Open

A new release? #1272

loskutov opened this issue Apr 29, 2024 · 3 comments

Comments

@loskutov
Copy link

Newer Linux distros (now including Ubuntu 24.04) have -D_FORITFY_SOURCE=3 in their default CFLAGS, leading to crashes with the last 0.9.8 release. It has been fixed in the upstream almost a year ago (92bec88) but there never was a release including the fix.

@everything411
Copy link

Arch also enables -D_FORITFY_SOURCE=3 now and rtorrent crashes on Arch too.

@alcohol
Copy link

alcohol commented May 3, 2024

I think both mean _FORTIFY_SOURCE, but I too can can confirm this is causing buffer overflow crashes. Is there any way we could help expedite a new release?

@everything411
Copy link

_FORTIFY_SOURCE=3 enables execution time object size check, see https://www.gnu.org/software/libc/manual/html_node/Source-Fortification.html.

snprintf(buf + strlen(buf), 255, ":+%i\n", getpid()); cannot pass the check because buffer_length_of(buf + strlen(buf)) < 255 and the program is aborted here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants