New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails with LTO #1264
Comments
Correct me if I'm misunderstanding, but I doubt rTorrent will ever officially support gentoo's build system, but even if I wanted to help unofficially, there's not any information on how to reproduce. |
The best way to reproduce would be to open the attachment titled "full logs" and check for information on how to reproduce. In short, Gentoo is not using an alternative build system, there's nothing specific to Gentoo here. It's just running configure and make. I would be happy to provide any additional details needed but if we can't agree on whether or not the official configure and make scripts were used then I'm not sure how much anything I say matters. |
So there's no set of emerge commands I could run to quickly reproduce on a gentoo docker image or anything? I spent some time looking at the log, and tried |
In the Gentoo container, if you add these flags to
Note: -flto is needed to produce LTO code generation, and the -Werror=* flags cause the link-time "lto-wrapper" based codegen to fatally error when safety constraints are violated. In principle it should reproduce with a plain configure and make, when using those flags. I hastily tried that with rtorrent from a git clone, but it didn't appear to compile due to libtorrent version differences and I didn't have time right then to chase that down. "Probably", using those flags on your own system with your own toolset versions and whatever configure command you usually use, would be enough too. |
I gave it enough of an effort to ensure that it's really LTO shenanigans at play, rather than a true ODR violation. It doesn't seem insurmountable, so maybe I'll take another shot later, but all the solutions I found didn't seem to be worth the increase in complexity. |
@eli-schwartz I resolved this issue in my version of rTorrent. The fix was very simplistic. It will build with LTO now on Gentoo Linux. Just need to run git clone if you're interested and follow the build instructions: |
Cool :) is there a PR including that commit? |
No, I had to rebuild the repo to get the commit history. There's just a commit. |
Full logs: build.log
Downstream report: https://bugs.gentoo.org/861848
The text was updated successfully, but these errors were encountered: