Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to ignore deprecated versions #624

Closed
2 tasks done
ghost opened this issue Jan 31, 2020 · 4 comments
Closed
2 tasks done

Option to ignore deprecated versions #624

ghost opened this issue Jan 31, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Jan 31, 2020

  • node version: 12.13.0
  • npm version: 6.12.0
  • npm-check-updates version: 4.0.1

Sometimes package authors release a new version by mistake and they mark such release as deprecated. For example: https://www.npmjs.com/package/primeng?activeTab=versions

image

But npm-check-updates still suggests to update to the latest version:
image

Can anything be done about it?

@raineorshine
Copy link
Owner

The deprecation status is retrieved with pacote:

$ pacote packument primeng | grep deprecated
      "deprecated": "Invalid configuration, use primeng-lts@8.1.3 instead"
      "deprecated": "Invalid configuration, use primeng-lts@8.1.x instead"

Which is what npm-check-updates uses to fetch package data.

So, yes, deprecated versions could be ignored if the deprecated field was checked.

@raineorshine
Copy link
Owner

It's probably a good practice for package authors to update their latest tag to a non-deprecated version.

Still, I don't see any downside to ncu printing a message and filtering deprecated versions out if one is detected.

@Jaimeloeuf
Copy link

Hey @raineorshine thanks for the explanation for this, but is there any updates on this? Since jkbrzt/rrule#417 issues like this still happen fairly frequently, it would be great if this package ignores the deprecated versions by default!

@raineorshine
Copy link
Owner

Fixed and published in v9.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants