Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pnpm v9 #1091

Open
1 task done
beefancohen opened this issue Apr 19, 2024 · 4 comments
Open
1 task done

Support for pnpm v9 #1091

beefancohen opened this issue Apr 19, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@beefancohen
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When upgrading our service to use pnpm v9, nixpacks is still using pnpm v8

package.json

  "engines": {
    "node": "18.x"
  },
  "packageManager": "pnpm@9.0.3",

build logs

11:12:24 AM ╔══════════════════════════════ Nixpacks v1.21.3 ══════════════════════════════╗
11:12:24 AM ║ setup      │ nodejs_18, pnpm-8_x, openssl                                    ║
11:12:24 AM ║──────────────────────────────────────────────────────────────────────────────║
11:12:24 AM ║ install    │ pnpm dlx turbo prune --scope=tono-marketing && cd /app/out &&   ║
11:12:24 AM ║            │ pnpm install                                                    ║
11:12:24 AM ║──────────────────────────────────────────────────────────────────────────────║
11:12:24 AM ║ build      │ cd /app/out && pnpm dlx turbo run build                         ║
11:12:24 AM ║──────────────────────────────────────────────────────────────────────────────║
11:12:24 AM ║ start      │ cd /app/out && pnpm dlx turbo run start                         ║
11:12:24 AM ╚══════════════════════════════════════════════════════════════════════════════╝
11:12:24 AM 

To reproduce

No response

Expected behavior

Nixpacks (corepack by proxy) respects the packageManager field

Environment

nixpacks version 1.21.3
aws codebuild

@beefancohen beefancohen added the bug Something isn't working label Apr 19, 2024
@coffee-cup
Copy link
Contributor

Hmm Nixpacks should definitely be using corepack to install pnpm 9. Looks like we are not for pnpm for some reason.

@mrlubos
Copy link

mrlubos commented Apr 20, 2024

I believe I have the same issue, downgrading to pnpm v8.x solved it for me :(

@abtestingalpha
Copy link

abtestingalpha commented May 14, 2024

Have the same issue here on pnpm 9. Our service is in a monorepo, and the rest of the app depends on v9, so unfortunately can't downgrade to v8. Using a nixpacks.toml file installing v9 works:

providers = ["node"]

[phases.install]
cmds = ["npm install -g corepack", "corepack enable", "corepack prepare pnpm@9.1.0 --activate", "pnpm install"]

However, would appreciate support for v9 out of the box.

@gBusato
Copy link

gBusato commented May 20, 2024

Have the same issue here on pnpm 9. Our service is in a monorepo, and the rest of the app depends on v9, so unfortunately can't downgrade to v8. Using a nixpacks.toml file installing v9 works:

providers = ["node"]

[phases.install]
cmds = ["npm install -g corepack", "corepack enable", "corepack prepare pnpm@9.1.0 --activate", "pnpm install"]

However, would appreciate support for v9 out of the box.

Thanks for the tips, it did work for me !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants