Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add asdf support to python + poetry #1042

Open
iloveitaly opened this issue Jan 10, 2024 · 7 comments
Open

add asdf support to python + poetry #1042

iloveitaly opened this issue Jan 10, 2024 · 7 comments

Comments

@iloveitaly
Copy link
Contributor

Feature request

The idea here is to support asdf/.tool-versions for specifying python + poetry versions. This could then
be extended to support node, go, etc in the future but my initial use case is scoped to python.

Motivation

No response

Contribution

#1026

Copy link
Contributor

Hello, @iloveitaly! Thanks for your submission.

Our team will respond soon. If you need more immediate help, try our Forum or our Discord. Thanks!

@zuchka
Copy link
Contributor

zuchka commented Jan 13, 2024

@iloveitaly sorry about the delays--I'm looking into this...

@zuchka
Copy link
Contributor

zuchka commented Jan 13, 2024

folks seem to like this proposal. Are you interested in finishing your PR? It looks like it's not quite done...

@zuchka
Copy link
Contributor

zuchka commented Jan 13, 2024

@iloveitaly also check this out:
#1017 (comment)

maybe worth hopping on that thread? how would this PR interface with that solution?

@coffee-cup
Copy link
Contributor

Hi @iloveitaly,
I think having a full on asdf provider could be a good idea. Basically if .tool-versions file is found at the root, then we install asdf and all packages defined. Would you be interested in creating a PR for this?

The problem with #1026 is that Nix does not support specifying the exact version of packages. It only supports the latest major/minor version. So parsing a tool-version file and then passing the version to Nix does not make a lot of sense in that case.

@iloveitaly
Copy link
Contributor Author

@coffee-cup That makes sense—What do you think about just extracting the major/minor version from asdf and passing that down to the Python builder?

@coffee-cup
Copy link
Contributor

That works as a good first step!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants