Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined method `silence' for nil (NoMethodError) with latest rails main #168

Closed
dorianmariecom opened this issue Mar 8, 2024 · 2 comments · May be fixed by #175
Closed

undefined method `silence' for nil (NoMethodError) with latest rails main #168

dorianmariecom opened this issue Mar 8, 2024 · 2 comments · May be fixed by #175

Comments

@dorianmariecom
Copy link

It happened between rails 917b6b2908510fbbc8d55db6360220485324e63c and rails 608c1bfe17a2626304b6aae96a3824517fc07bb2

07:00:38 web.1  | /Users/dorianmariefr/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/solid_queue-0.2.2/lib/solid_queue/processes/poller.rb:14:in `with_polling_volume': undefined method `silence' for nil (NoMethodError)
07:00:38 web.1  | 
07:00:38 web.1  |           ActiveRecord::Base.logger.silence { yield }
07:00:38 web.1  |                                    ^^^^^^^^
07:00:38 web.1  | 	from /Users/dorianmariefr/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/solid_queue-0.2.2/lib/solid_queue/dispatcher.rb:31:in `dispatch_next_batch'
07:00:38 web.1  | 	from /Users/dorianmariefr/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/solid_queue-0.2.2/lib/solid_queue/dispatcher.rb:22:in `run'
07:00:38 web.1  | 	from /Users/dorianmariefr/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/solid_queue-0.2.2/lib/solid_queue/processes/runnable.rb:48:in `block (2 levels) in do_start_loop'
@dorianmariecom
Copy link
Author

It was because I had config.active_record.logger = nil

dorianmariecom added a commit to dorianmariecom/solid_queue that referenced this issue Mar 8, 2024
@dorianmariecom
handle config.active_record.logger = nil
8067e2c 
FIxes rails#168
@dorianmariecom dorianmariecom mentioned this issue Mar 8, 2024
Closed
dorianmariecom added a commit to dorianmariecom/solid_queue that referenced this issue Mar 11, 2024
@dorianmariecom
handle config.active_record.logger = nil
f09121d 
FIxes rails#168
@dorianmariecom dorianmariecom mentioned this issue Mar 11, 2024
Open
dorianmariecom added a commit to dorianmariecom/solid_queue that referenced this issue Mar 11, 2024
@dorianmariecom
Support nil logger and ActiveSupport::Logger not Logger
e366eca 
FIxes rails#168
dorianmariecom added a commit to dorianmariecom/solid_queue that referenced this issue Mar 11, 2024
@dorianmariecom
handle config.active_record.logger = nil
176d697 
FIxes rails#168
@jeremy
Copy link
Member

jeremy commented Mar 12, 2024

Continued in #175

@jeremy jeremy closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jeremy @dorianmariecom