Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean up #14

Open
elie222 opened this issue Sep 27, 2023 · 2 comments
Open

Code clean up #14

elie222 opened this issue Sep 27, 2023 · 2 comments

Comments

@elie222
Copy link

elie222 commented Sep 27, 2023

While studying the codebase, some low hanging issues to clean up the codebase I'd address are:

  • Add Prettier.
  • Fix up warnings. A lot of yellow warnings across the app.
  • Remove unused packages.

Beyond that:

  • Remove hard coded localhost strings.
  • Will production version write version files to disk? Or use a database?

I know the v1 was put together very quickly which is why much of this wasn't addressed.

@pi0
Copy link
Collaborator

pi0 commented Sep 27, 2023

Hi! Part of it is added via #9

@elie222
Copy link
Author

elie222 commented Oct 5, 2023

You've added too many changes in one commit. You've changed 1600 files and there's way more changes than just Prettier.

One commit that adds Prettier and cleans up the entire codebase + runs it on each commit with something like pretty-quick is the main things that's needed.

The core maintainer @raidendotai needs to do it one time, because any other changes he makes will conflict with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants