Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi using IE 11.0.9 and its showing Red (win 7 64bit) #30

Open
mikefurr opened this issue Jul 4, 2014 · 11 comments
Open

Hi using IE 11.0.9 and its showing Red (win 7 64bit) #30

mikefurr opened this issue Jul 4, 2014 · 11 comments

Comments

@mikefurr
Copy link

mikefurr commented Jul 4, 2014

your page say should be Yellow ?

@jl2035
Copy link

jl2035 commented Jul 20, 2014

Me to ... the same issue on two different PCs. If you are running windoz and ie, it adds .gecko to the html tag, not .ie

@jl2035
Copy link

jl2035 commented Jul 20, 2014

@chrisblakley
Copy link

I've been detecting IE11 using this conditional (jQuery, but could be converted to raw JS):

if ( Object.hasOwnProperty.call(window, "ActiveXObject") && !window.ActiveXObject ) {
    jQuery('html').addClass('ie ie11');
}

@jl2035
Copy link

jl2035 commented Jul 24, 2014

I fixed it by detecting the Trident token. Forked the repo here:
https://github.com/jl2035/css_browser_selector

I will try to add a special ie 11 detection, distinguishable from other ie versions.

@isarmstrong
Copy link

@jl2035 On line 111, update your repo to:

(is('windows nt 6.3')?' win8.1'
:is('windows nt 6.2')?' win8'

Should give you the matching set.

@isarmstrong
Copy link

Actually, you'll want all of this:

(!(/opera|webtv/i.test(ua))&&/msie\s(\d+)/.test(ua))?('ie ie'+(/trident\/7\.0/.test(ua) ? '11' : RegExp.$1))
            :is (!(/opera|webtv/i.test(ua))&&/msie\s(\d+)/.test(ua))?('ie ie'+(/trident\/6\.0/.test(ua) ? '10' : RegExp.$1))
            :is (!(/opera|webtv/i.test(ua))&&/msie\s(\d+)/.test(ua))?('ie ie'+(/trident\/5\.0/.test(ua) ? '9' : RegExp.$1))
            :is (!(/opera|webtv/i.test(ua))&&/msie\s(\d+)/.test(ua))?('ie ie'+(/trident\/4\.0/.test(ua) ? '8' : RegExp.$1))

Although my script still tags IE6 as both 6 and 7.... debugging

All good actually, was an unrelated mistake.

@jl2035
Copy link

jl2035 commented Dec 3, 2014

Updated. Thanks.

It's been a while.. is my repo still relevant?

@isarmstrong
Copy link

In a Modernizr era, people are obviously encouraged to use feature
detection. I can see how that would make the repo seem irrelevant.

I updated it because my client has a product which, put simply, they don't
intend to ever fix for IE. It happens to work on IE11 though. The marketing
team wanted a way to politely disable the submission form and ask IE 5-10
users to download an alternate browser. A standard IE conditional comment
seemed messy compared with .ie11 .selector {display: inherit}, or the
ability to disable a field via jQuery based on .hasClass.

So the entire script isn't something I use very often - but in special
circumstances, it beats writing up my own regex test.

It can also be useful for resolving typography differences between
Firefox/IE and Webkit on Windows when the grid is highly specific.

On Wed, Dec 3, 2014 at 1:58 PM, p2035e notifications@github.com wrote:

Updated. Thanks.

It's been a while.. is my repo still relevant?


Reply to this email directly or view it on GitHub.

@isarmstrong
Copy link

Whoops, I thought that was the OP. Neevermind. Feel free to merge the rest of my changes. https://github.com/isarmstrong/css_browser_selector

@jl2035
Copy link

jl2035 commented Dec 3, 2014

Oh. But my repo was created just beacuse of ie11 issue. This is fixed in your repo by now, if I understand correctly. So yeah.. mine is irelevant, I think.

I guess I will just delete..

@isarmstrong
Copy link

Yeah I added support for all missing IE versions, Win 8.1, and a new
index.html that tests the user's browser + lists classes applied. It should
really be merged in here.

Rafel is still around and very active on Github. I have to assume he is
waiting for this project to die. Unfortunately, there are still times when
detecting a browser is useful.

On Wed, Dec 3, 2014 at 3:40 PM, p2035e notifications@github.com wrote:

Oh. But my repo was created just beacuse of ie11 issue. This is fixed in
your repo by now, if I understand correctly. So yeah.. mine is irelevant, I
think.

I guess I will just delete..


Reply to this email directly or view it on GitHub
#30 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants