Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotations support Python codebase enhancement. (REP-4) #70

Open
1 of 2 tasks
Almas-Ali opened this issue Apr 16, 2024 · 3 comments · Fixed by #125
Open
1 of 2 tasks

Type annotations support Python codebase enhancement. (REP-4) #70

Almas-Ali opened this issue Apr 16, 2024 · 3 comments · Fixed by #125
Labels
core System level core enhancement New feature or request proposal Radon Enhancement Proposal (REP)

Comments

@Almas-Ali
Copy link
Member

Almas-Ali commented Apr 16, 2024

Our hole codebase need to refactor as soon as possible before it’s too late. We have to support type annotations before too much unknown bugs encounter.

We will make sure it pass all tests on mypy static checking. Currently, it’s a proposal.

Part of Radon Enhancement Proposal - 4 (REP-4)

Work list:

  • mypy static checking should pass every source file testing.

Nothing more for now here. A huge refactoring needed here.

Update:

  • mypy --strict . have to pass this checks.
@Almas-Ali Almas-Ali added enhancement New feature or request core System level core proposal Radon Enhancement Proposal (REP) labels Apr 16, 2024
@Almas-Ali Almas-Ali pinned this issue Apr 16, 2024
@Almas-Ali Almas-Ali changed the title Type annotations support. REP-4 Type annotations support. (REP-4) Apr 16, 2024
@Almas-Ali Almas-Ali changed the title Type annotations support. (REP-4) Type annotations support Python codebase enhancement. (REP-4) Apr 20, 2024
@Almas-Ali Almas-Ali linked a pull request May 1, 2024 that will close this issue
Almas-Ali added a commit that referenced this issue May 1, 2024
Add type annotations to Python codebase (REP-4 #70)
@Almas-Ali Almas-Ali reopened this May 1, 2024
@angelcaru
Copy link
Contributor

???

@Almas-Ali
Copy link
Member Author

This is not over yet!! 😐
Still getting issue in my VSCode in strict mode enabled. Every line is Red flagged. We need to fulfil mypy --strict . checking. I don’t want any runtime error in future. Hole codebase need to be secure. Each and every code have to be strictly checked.

We need to do it anyway.

@angelcaru
Copy link
Contributor

no

@Almas-Ali Almas-Ali unpinned this issue May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core System level core enhancement New feature or request proposal Radon Enhancement Proposal (REP)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants