Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog component should use HTML dialog #2857

Open
Bricklou opened this issue Apr 21, 2024 · 0 comments
Open

Dialog component should use HTML dialog #2857

Bricklou opened this issue Apr 21, 2024 · 0 comments

Comments

@Bricklou
Copy link

Bug report

Current Behaviour

The current implementation for the dialog use portal with div to render the dialog.
Copie d'écran_20240421_110251

Expected behavior

The dialog component should use the native HTML dialog behaviour to render it. This way, there will be no need to do any kind of very trick to make the z-index property work as expected.

Reproducible example

Suggested solution

The dialog component should use the HTML dialog to render, taking advantage of the #top-layer context provided by the browser to render on top of other elements on the page.

Your environment

Software Name(s) Version
Radix Package(s) @radix-ui/react-dialog ^1.0.5
React n/a ^18.2.0
Browser Edge 123.0.2420.81
Assistive tech
Node n/a 20.12.2
npm/yarn pnpm 8.15.4
Operating System Archlinux 6.8.7-arch1-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant