Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Cookie' to private_headers in Radiant::Cache? #362

Open
jfahrenkrug opened this issue Feb 6, 2013 · 2 comments
Open

Add 'Cookie' to private_headers in Radiant::Cache? #362

jfahrenkrug opened this issue Feb 6, 2013 · 2 comments
Milestone

Comments

@jfahrenkrug
Copy link
Member

Since rack-cache 1.2, the list of default private_headers options is ['Authorization', 'Cookie'] (About private_headers: http://rtomayko.github.com/rack-cache/configuration). However in https://github.com/radiant/radiant/blob/1.1.2/lib/radiant/cache.rb we only pass in ['Authorization']. Is that intentional? Shouldn't we add Cookie as well? Or am I overlooking unwanted side effects?

Related info: #361

  • Johannes
@saturnflyer
Copy link
Member

I've done this on the master branch. This should be configurable in the latest release in environment.rb (assuming it works correctly)

@jfahrenkrug
Copy link
Member Author

Great, thanks Jim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants