Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paperclip.additional_thumbnails isn’t respected #51

Open
gerrit opened this issue Dec 4, 2011 · 11 comments
Open

paperclip.additional_thumbnails isn’t respected #51

gerrit opened this issue Dec 4, 2011 · 11 comments

Comments

@gerrit
Copy link
Member

gerrit commented Dec 4, 2011

While its mentioned in the README, it doesn’t have any effect (it isn’t accessed anywhere in the code). Is this intentional? If so, what is the replacement method to specify custom sizes?

@ghost
Copy link

ghost commented Dec 4, 2011

are assets.thumbnails.image, assets.thumbnails.video and assets.thumbnails.pdf what you're looking for?

@gerrit
Copy link
Member Author

gerrit commented Dec 7, 2011

Yes, thats it. I'll update the docs soon.
There is support for a legacy option called “assets.additional_thumbnails”. Was that ever in use? If so we'd need to support both legacy options

@ghost
Copy link

ghost commented Dec 7, 2011

looks like additional_thumbnails was part of the original paperclipped extension. http://git.io/8-XYHA#L161-163

@gerrit gerrit closed this as completed Dec 9, 2011
@gerrit gerrit reopened this Dec 9, 2011
@gerrit
Copy link
Member Author

gerrit commented Dec 9, 2011

whoops, wrong issue number in commit

@gerrit
Copy link
Member Author

gerrit commented Dec 9, 2011

Ok so even paperclipped never used paperclip.additional_thumbnails.
I think the real issue here is that the documentation states to use paperclip.additional_thumbnails when that never worked. I might be the only one that followed the docs, but I still think we should handle that gracefully. I'll patch the legacy support code too if that’s ok

@lelesrc
Copy link

lelesrc commented Dec 13, 2011

We followed the doc too...

@ghost
Copy link

ghost commented Dec 13, 2011

but paperclip.additional_thumbnails never did anything right? so by aliasing it to assets.thumbnails.image we'll actually be changing behavior right? i'm fine with that since doing nothing was obviously not the right thing; just trying to figure out what behavior was expected. (yeah i never really used the paperclipped extension or read the clipped docs so sorry if this is a stupid question)

@lelesrc
Copy link

lelesrc commented Dec 13, 2011

is there a known workaround for this issue?
basically, we just need to add "strip=180x100>" to our thumbnails list...

@ghost
Copy link

ghost commented Dec 13, 2011

@youleaf the workaround is to use the real config settings: assets.thumbnails.image, assets.thumbnails.video and assets.thumbnails.pdf

the fix is to update the docs and possibly alias paperclip.additional_thumbnails to assets.thumbnails.image

@saturnflyer
Copy link
Member

@johnmuhl updated this extension to add clipped_config.rb

Is this still an issue?

@ghost
Copy link

ghost commented Jan 7, 2012

we still need some changes to the readme to remove references to stuff like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants