Dotted lines for conditional jumps in graph

[cyanpencil]

Closes #204

Added new config var: graph.dotted, default to False.

Fixed a bunch of bugs utf8 related in canvas too.

[cyanpencil]

I've set it as [WIP] cause I want to know if the code can be refactored better... especially this: do I absolutely need to add the dotted boolean argument to every call of draw_horizontal_line and draw_vertical_line ? Is there a more elegant way of doing this?

[XVilka]

So far looks good. Regarding the dotted? checks - you might convert those lines in some macro instead.

[Maijin]

Why default to false?

[radare]

Why use dotted lines in all lines by default? This makes no sense

…

On 26 Jul 2018, at 07:50, Maijin ***@***.***> wrote: Why default to false? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[XVilka]

@radare who said it is used in all lines? It is only used for conditional jumps.

[Maijin]

Yeah it's only for conditional jumps not for everything that's why i don't see why it's disabled by default :S

[cyanpencil]

I initially set up this feature to default because I was not sure it looked good enough to by default

Now refactored to use macros to make code a bit cleaner, and set up default of graph.dotted to true.
(But you still have to set scr.utf8 to true). Is it ok for you @radare ?

[Maijin]

Can you do a screenshot of the new one maybe?

[cyanpencil]

Can you do a screenshot of the new one maybe?

I didn't change anything about the rendering, I only refactored code, the result is the same ass the screen I posted before.
The main thing is that "dot" effect changes from font to font; e.g. here's a screen in urxvt using font Dejavu sans mono:

[radare]

I dont see the point on having dotted lines on consitional jumps. Its just useless. Consitional lines are red and gteen. Uncomditional ones are blue. The only reason to use dotted lines is for lines that go backward or to symbolize loops.

…

On 26 Jul 2018, at 11:53, Maijin ***@***.***> wrote: Yeah it's only for conditional jumps not for everything that's why i don't see why it's disabled by default :S — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[XVilka]

I don't agree. Not everyone can see colors, moreover it will improve our users' experience who use Braille screens.

…

On Fri, Jul 27, 2018, 12:44 AM radare ***@***.***> wrote: I dont see the point on having dotted lines on consitional jumps. Its just useless. Consitional lines are red and gteen. Uncomditional ones are blue. The only reason to use dotted lines is for lines that go backward or to symbolize loops. > On 26 Jul 2018, at 11:53, Maijin ***@***.***> wrote: > > Yeah it's only for conditional jumps not for everything that's why i don't see why it's disabled by default :S > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10814 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMZ_dYbAtWVcdHZ8hwSG_KiUQXqOg7yks5uKfHvgaJpZM4VdK8-> .

[Maijin]

As discussed, can you add dotted lines for lines that go backward or to symbolize loops too?

[Maijin]

with a different symbol

[cyanpencil]

As discussed, can you add dotted lines for lines that go backward or to symbolize loops too?

Sure, will do :)

[radare]

There was t and f hints before to denote this before. In fact it was showing that t and f along the line which is imho way better than dotted lines to understand what it means

…

On 26 Jul 2018, at 17:52, Anton Kochkov ***@***.***> wrote: I don't agree. Not everyone can see colors, moreover it will improve our users' experience who use Braille screens. On Fri, Jul 27, 2018, 12:44 AM radare ***@***.***> wrote: > I dont see the point on having dotted lines on consitional jumps. Its just > useless. > > Consitional lines are red and gteen. Uncomditional ones are blue. > > The only reason to use dotted lines is for lines that go backward or to > symbolize loops. > > > On 26 Jul 2018, at 11:53, Maijin ***@***.***> wrote: > > > > Yeah it's only for conditional jumps not for everything that's why i > don't see why it's disabled by default :S > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub, or mute the thread. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#10814 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAMZ_dYbAtWVcdHZ8hwSG_KiUQXqOg7yks5uKfHvgaJpZM4VdK8-> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.