New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorize function arguments #10752
Colorize function arguments #10752
Conversation
Update the themes |
@cyanpencil what about reusing the same color also in the comments which mark types of the argument:
So this |
But there is on problem though . not all type/name are mapped with variable, also the address where the comment is present and address where var is accesed could be different , so it would be difficult to find the address of instruction having this comment and map with the variables |
@sivaramaaa this is true, but I am not suggesting to map them somehow, I suggest just to use the same color from the theme |
ah i get it , cool 👍 |
+1 on reusing. Otherwise doing themes is boring
… On 17 Jul 2018, at 06:07, Anton Kochkov ***@***.***> wrote:
@cyanpencil what about reusing the same color also in the comments which mark types of the argument?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@radare what do you mean by that? There are way too many themes to update manually, and I have no idea on which colors to use to be consistent with those...
@XVilka Ok, will do it, shouldn't be hard. Do you think I should also color variable names in disasm with the same color as in the function beginning? Like |
@cyanpencil make it white color for those themes you don't care, so ppl will send a fixes eventually. Regarding variable names in the disasm - good idea too. |
if you reuse another color theres no need to change all the themes |
if func* ones are already there you are reusing them :P i just dont wanna have over 9000 options for colors, we must find a balance |
nvm, do you want to update the themes in this PR?, as long as none have it yep it is a save merge. But we must have the themes updated before 2.8 |
@cyanpencil can you please use the same color in types and variable names as we discussed ? |
@XVilka yes I am currently working on it, but since it turned out to be a bit more complex I'll be doing that in a separate pr |
Closes #10614
They are governed by config variable
scr.color.args
Their palette names are
func_arg
,func_arg_type
,func_arg_addr
.Please say here if you do not agree with the defaults I chose (I did not spend too much time selecting them), or you think they should be given a different name.