Fix some last coverities #10735
Merged
Fix some last coverities #10735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the wrong tests are all due to the recent changes in r2regressions, but let's wait that they get resolved to be 100% sure |
cyanpencil
force-pushed
the
fix-coverities
branch
5 times, most recently
from
21de862
to
5bda075
Compare
radare
reviewed
Jul 16, 2018
libr/asm/asm.c
Outdated
| @@ -309,10 +309,12 @@ R_API int r_asm_use(RAsm *a, const char *name) { | |||
| r_list_foreach (a->plugins, iter, h) { | |||
| if (!strcmp (h->name, name) && h->arch) { | |||
| if (!a->cur || (a->cur && strcmp (a->cur->arch, h->arch))) { | |||
| char *file = r_str_newf ("%s/%s.sdb", r_str_r2_prefix (R2_SDB_OPCODES), h->arch); | |||
| char *r2prefix = r_str_r2_prefix (R2_SDB_OPCODES); | |||
| char *file = r_str_newf ("%s/%s.sdb", r2prefix, h->arch); | |||
There was a problem hiding this comment.
r2prefix can be null, so better use r_str_get in here to avoid the undefined behaviour of passing NULL to %s. or just if (r2prefix) { ...
cyanpencil
force-pushed
the
fix-coverities
branch
from
5bda075
to
404d971
Compare
|
please rebase. master should be green |
cyanpencil
force-pushed
the
fix-coverities
branch
2 times, most recently
from
33b19a1
to
030f0d5
Compare
cyanpencil
force-pushed
the
fix-coverities
branch
from
030f0d5
to
d94d803
Compare
|
Ok finally green now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.