Fix #10690 + fix delete_dup_edges #10728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10690
Before:
After:
Also, there were some errors in the delete_dup_edges function I introduced in my last pr:
ASAN gave a use after free, which was fixed by using r_list_foreach_safe and a bit of iterator pointer juggling
It made more than half of useless checks. Now it takes at least half the time (however I didn't measure how much it impacted overall performance)