Fix #10719 line graph not correctly #10721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVilka
reviewed
Jul 13, 2018
| @@ -2125,6 +2125,23 @@ static void get_bbupdate(RAGraph *g, RCore *core, RAnalFunction *fcn) { | |||
| core->anal->stackptr = saved_stackptr; | |||
| } | |||
|
|
|||
| static void delete_dup_edges (RAGraph *g) { | |||
There was a problem hiding this comment.
This would probably slow down graphs a bit, but correctness is more important
There was a problem hiding this comment.
Lets keep optimization for later then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10719
Basically the fix was letting r2 set up duplicate edges AT FIRST,
then deleting them after r2 set up backedges.
Not allowing dup edges was interfering with backedges or edges drawing in general, in particular cases (where there was a backedge from a direct neighbour).