Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact xrefs #10718

Merged
merged 3 commits into from Jul 14, 2018
Merged

Compact xrefs #10718

merged 3 commits into from Jul 14, 2018

Conversation

cyanpencil
Copy link
Contributor

Closes #10253

2018-07-12-040420_682x176_scrot

Copy link
Contributor

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems right (apart the free of name), though I think a bit of refactoring would help... the two parts are quite similar. Probably though It wouldn't be easy

next_fun = r_anal_get_fcn_in (core->anal, next_addr, -1);
if (next_fun && next_fun->addr == fun->addr) {
r_list_append (addrs, refi->addr);
continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is not freed

next_f = r_flag_get_at (core->flags, next_addr, true);
if (next_f && f->offset == next_f->offset) {
r_list_append (addrs, refi->addr - f->offset);
continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is not freed

@cyanpencil
Copy link
Contributor Author

Thanks for the feedback @ret2libc ,
you are absolutely right about the missing free, I'll fix it right now.
I'll try also to refactor the two similar pieces into one, but I'm not very sure on how to do that right now ^^

@ret2libc
Copy link
Contributor

Yeah don't worry about the refactoring.. It was just a comment, but I guess for the moment it's ok as it is... I don't see an easy way to refator this either

@XVilka XVilka merged commit 704a497 into radareorg:master Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants