New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact xrefs #10718
Compact xrefs #10718
Conversation
1f132d0
to
5f4bda1
Compare
5f4bda1
to
00fce4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change seems right (apart the free of name), though I think a bit of refactoring would help... the two parts are quite similar. Probably though It wouldn't be easy
next_fun = r_anal_get_fcn_in (core->anal, next_addr, -1); | ||
if (next_fun && next_fun->addr == fun->addr) { | ||
r_list_append (addrs, refi->addr); | ||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name
is not freed
next_f = r_flag_get_at (core->flags, next_addr, true); | ||
if (next_f && f->offset == next_f->offset) { | ||
r_list_append (addrs, refi->addr - f->offset); | ||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name
is not freed
Thanks for the feedback @ret2libc , |
Yeah don't worry about the refactoring.. It was just a comment, but I guess for the moment it's ok as it is... I don't see an easy way to refator this either |
Closes #10253