Improve jmptbl edges, second try #10662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this is my second try at improving jump tables edges. Here are the main changes:
If a node has more than 2 edges, than those edges are centered in the middle of the node
If a node has more than 2 edges, those edges are sorted based on the x coordinate of their destination. This way they won't overlap when "bending". You can test this by moving the switch block with H and L and see how the bendpoints change accordingly.
Edges with the same origin and destination are merged, so that we have only one edge for multiple cases in one node, resulting in much more clear screen when there is a jumptable.
Killed the graph.altedgepos variable that I introduced in my last pr.
This is before:
This is after:
I tried to test it a lot, there are still a few minor things to fix but this should clear up all the major messes.