Support for fullwidth characters of the CJK charset (Chinese, Japanese, Korean). #10579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R2 doesn't support fullwidth characters (chars that take up two cells of the terminal), this can be reproduced easily by creating a comment like
CC 逆向工程
and going to either visual disasm, graph or panels view.Sometimes the line right below gets duplicated, or the panels and graph layout break down:
This is because those characters occupy two cells instead of one, thus messing up all layout calculations:
This pr is intended to fix those kind of things. Please, test it if you can, as there are a lot of corner cases. I fixed all of the things I could see, but I'm not sure I've got them all.